Date: Tue, 19 Jun 2018 08:57:21 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335244 - head Message-ID: <b236a0dc-ebad-ef02-4956-d99d98de6dd5@FreeBSD.org> In-Reply-To: <201806160502.w5G52CIO039774@slippy.cwsent.com> References: <201806160502.w5G52CIO039774@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ItbHzN6ozFf4ZGAE6vb7CtxR65GUJboYk Content-Type: multipart/mixed; boundary="FyYr4GhKXSz7igo7cbrSUOpkrYH5yp70l"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <b236a0dc-ebad-ef02-4956-d99d98de6dd5@FreeBSD.org> Subject: Re: svn commit: r335244 - head References: <201806160502.w5G52CIO039774@slippy.cwsent.com> In-Reply-To: <201806160502.w5G52CIO039774@slippy.cwsent.com> --FyYr4GhKXSz7igo7cbrSUOpkrYH5yp70l Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/15/2018 10:02 PM, Cy Schubert wrote: > In message <201806160436.w5G4aXks039566@slippy.cwsent.com>, Cy Schubert= =20 > writes: >> In message <201806160035.w5G0ZJfd066325@repo.freebsd.org>, Bryan=20 >> Drewery writes >> : >>> Author: bdrewery >>> Date: Sat Jun 16 00:35:19 2018 >>> New Revision: 335244 >>> URL: https://svnweb.freebsd.org/changeset/base/335244 >>> >>> Log: >>> Assert that a build is done before an install. >>> =20 >>> This should also catch cases where the wrong MAKEOBJDIRPREFIX is us= ed for >>> install. >>> =20 >>> MFC after: 2 weeks >>> Sponsored by: Dell EMC >>> >>> Modified: >>> head/Makefile.inc1 >>> >>> Modified: head/Makefile.inc1 >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >> =3D=3D >>> =3D >>> --- head/Makefile.inc1 Fri Jun 15 23:42:22 2018 (r335243) >>> +++ head/Makefile.inc1 Sat Jun 16 00:35:19 2018 (r335244) >>> @@ -89,7 +89,10 @@ MK_GCC_BOOTSTRAP=3D no >>> .if make(installworld) || make(install) || make(distributeworld) || = \ >>> make(stageworld) >>> .-include "${OBJTOP}/compiler-metadata.mk" >>> +.if !defined(_LOADED_COMPILER_METADATA) >>> +.error A build is required first. You may have the wrong MAKEOBJDIR= PREFIX >> s >>> et. >>> .endif >>> +.endif >>> =20 >>> # Pull in COMPILER_TYPE and COMPILER_FREEBSD_VERSION early. Pull it = from t >> he >>> # tree to be friendlier to foreign OS builds. It's safe to do so unc= onditi >> on >>> ally >>> @@ -195,6 +198,7 @@ compiler-metadata.mk: .PHONY .META >>> @: > ${.TARGET} >>> @echo ".info Using cached compiler metadata from build at $$(hostna= me)=20 >>> on $$(date)" \ >>> > ${.TARGET} >>> + @echo "_LOADED_COMPILER_METADATA=3Dt" >> ${.TARGET} >>> .for v in ${_COMPILER_METADATA_VARS} >>> @echo "${v}=3D${${v}}" >> ${.TARGET} >>> .endfor >>> >> >> Another data point: This also broke the following: >> >> cwsys# poudriere jail -c -m src=3D/opt/src/svn-current -j HEADi386 -a = i386 >> [00:00:00] Creating HEADi386 fs at /poudriere/amd64/jails/HEADi386... = >> done >> [00:00:01] Copying /opt/src/svn-current to /poudriere/amd64/jails/HEAD= i3 >> 86/usr/src... done >> [00:06:01] Starting make installworld >> --- installworld --- >> make[1]: "/export/obj/opt/src/svn-current/i386.i386/compiler-metadata.= mk >> " line 1: Using cached compiler metadata from build at cwsys on Fri Ju= n=20 >> 15 18:39:46 PDT 2018 >> make[1]: "/opt/src/svn-current/Makefile.inc1" line 93: A build is=20 >> required first. You may have the wrong MAKEOBJDIRPREFIX set. >> *** [installworld] Error code 1 >> >> make: stopped in /opt/src/svn-current >> 1 error >> >> make: stopped in /opt/src/svn-current >> [00:06:01] Error: Failed to 'make installworld' >> [00:06:01] Error while creating jail, cleaning up. >> [00:06:01] Removing HEADi386 jail... done >> [00:06:03] Cleaning HEADi386 data... done >> cwsys#=20 >=20 > Nevermind. I found it. Stupid error on my part. >=20 >=20 I'm curious what you did? Did you svn update after a buildworld and then tried installworld? That would fail 1 time here but not again in the future. (Thinking outloud now, I could probably reuse the vcsversion code in newvers.sh to record the build revision during buildworld and check it matches at installworld time, but the assumes the same vcs tool is on the install machine so it probably wouldn't work.) I'm happy to see it may have caught a subtle mistake for you. --=20 Regards, Bryan Drewery --FyYr4GhKXSz7igo7cbrSUOpkrYH5yp70l-- --ItbHzN6ozFf4ZGAE6vb7CtxR65GUJboYk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbKSfhAAoJEDXXcbtuRpfPpNQH/R2bhzkmYz+Gb7QpWL4F4p7z tNqk+iccP/9s2/aWKjq9rXnkPmwmK9c8kmhhdrvn9DZWboL7F6osYQ+oI0hUo7DO fXecZxYok5AxYOJo/+chyYdkEpkjT/EiftdehYoG2xHuWlXMHHUtanrbe5RHYg3X jSPYjFUcQMVvfqyWU8gXXIjapJrk4GNDa97pjD1Z0T04uE8+oAD/TD1r9VKsYcgB af6QBKb6xr9Qfoo6ZQ2I6dcuN+Fap6q6mSK3Ut9AfD+sOx8ewV/ju4mhZvG32pHu +VIQ/yaoieuboBkXACExWlBBWoCU4krlAKeB4cFImBwzqfl/EbuOG/iy9FTHwYg= =4miA -----END PGP SIGNATURE----- --ItbHzN6ozFf4ZGAE6vb7CtxR65GUJboYk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b236a0dc-ebad-ef02-4956-d99d98de6dd5>