From owner-freebsd-bugs@FreeBSD.ORG Mon Mar 7 14:40:07 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C044E1065670 for ; Mon, 7 Mar 2011 14:40:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 83F0A8FC15 for ; Mon, 7 Mar 2011 14:40:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p27Ee7V4002084 for ; Mon, 7 Mar 2011 14:40:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p27Ee7J8002083; Mon, 7 Mar 2011 14:40:07 GMT (envelope-from gnats) Resent-Date: Mon, 7 Mar 2011 14:40:07 GMT Resent-Message-Id: <201103071440.p27Ee7J8002083@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Urankar Mikael Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71A20106564A for ; Mon, 7 Mar 2011 14:32:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 60C858FC25 for ; Mon, 7 Mar 2011 14:32:42 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p27EWfl9081757 for ; Mon, 7 Mar 2011 14:32:41 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p27EWfvp081753; Mon, 7 Mar 2011 14:32:41 GMT (envelope-from nobody) Message-Id: <201103071432.p27EWfvp081753@red.freebsd.org> Date: Mon, 7 Mar 2011 14:32:41 GMT From: Urankar Mikael To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/155349: [patch] kbdmap segfault when rc.conf is non existent X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2011 14:40:07 -0000 >Number: 155349 >Category: bin >Synopsis: [patch] kbdmap segfault when rc.conf is non existent >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Mar 07 14:40:07 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Urankar Mikael >Release: >Organization: >Environment: FreeBSD iut-mir-o.ujf-grenoble.fr 9.0-CURRENT FreeBSD 9.0-CURRENT #39 r219368M: Mon Mar 7 12:15:50 CET 2011 murankar@iut-mir-o.ujf-grenoble.fr:/usr/obj/usr/src/sys/LETHE amd64 >Description: kbdmap segfault when rc.conf is non existent Here is the backtrace : Starting program: /usr/obj/usr/src/usr.sbin/kbdmap/kbdmap kbdcontrol: getting keymap: Inappropriate ioctl for device You are not on a virtual console - expect certain strange side-effects Could not open /etc/rc.conf for reading Program received signal SIGSEGV, Segmentation fault. 0x00000008009214e7 in fclose () from /lib/libc.so.7 (gdb) bt full #0 0x00000008009214e7 in fclose () from /lib/libc.so.7 No symbol table info available. #1 0x000000000040249c in main (argc=1, argv=0x7fffffffd9a8) at /usr/src/usr.sbin/kbdmap/kbdmap.c:232 No locals. >How-To-Repeat: Delete /etc/rc.conf and run kbdmap >Fix: Close the file stream only if it was successfully opened. Patch attached with submission follows: Index: kbdmap.c =================================================================== --- kbdmap.c (révision 219368) +++ kbdmap.c (copie de travail) @@ -226,10 +226,10 @@ } } } + fclose(fp); } else fprintf(stderr, "Could not open %s for reading\n", sysconfig); - fclose(fp); return fnt; } >Release-Note: >Audit-Trail: >Unformatted: