From owner-svn-src-all@freebsd.org Tue May 7 07:16:19 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE14E15A1425; Tue, 7 May 2019 07:16:18 +0000 (UTC) (envelope-from chagin.dmitry@gmail.com) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7A59474E01; Tue, 7 May 2019 07:16:18 +0000 (UTC) (envelope-from chagin.dmitry@gmail.com) Received: by mail-io1-f42.google.com with SMTP id y6so13419452ior.5; Tue, 07 May 2019 00:16:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wBJx5v2Rz1l4apBGmFjWudAwXVfqbqwLWjWolhWQ/dI=; b=O8X0N/6YuRk/kJ01gPPDOYg2cL7EF7HgpzsmhbOWWMJE/fF13IMOvMkrAvmqxociAr OpM7L7FMjvQ1N/zBEOQyc/zGX2a19rE7Q81OCcLKfAOHPNA1tmMYQiB7LQ97ImqDNe4D iieVuC6IFgMy6WBtZP1mHZo6MIWgpGH4vY6iQ0SZefWBSywNbkw79CmwksiqbR4IJ4QC 2vBK+Wt9G6qIgfGI7KzMwYqsStz5dgw2V7AyNToml2ui/bhbqVktZXw2iMTvjVsgkd2L XH60f3Euablncg10Bk2SHS6V0e9kww6MvpI2+rQ3t3zSwXTfWXxvc5P39qVebFCMfZ10 ZAlQ== X-Gm-Message-State: APjAAAXzFMHwXVVJX7JlsjlNRvrhYIeK3KnMwk2PxSBF9Pv0Ds5/14+c LqQZ0Aql+sz/LMt2uB1IHLkpLsMZwUeTFXSdMjDtZ7lTux0= X-Google-Smtp-Source: APXvYqyc+Lkg92yvu0eUrq1lt+9SkiYzVTxR6dZx0c15rU9IHKHrSgGdnWHS/FZ2Q+ILL/YFHO7RzJenyu0v8gawV4w= X-Received: by 2002:a6b:1494:: with SMTP id 142mr2162222iou.199.1557207956066; Mon, 06 May 2019 22:45:56 -0700 (PDT) MIME-Version: 1.0 References: <201905070508.x4758DW5015688@repo.freebsd.org> <201905070531.x475VuIY010069@gndrsh.dnsmgr.net> In-Reply-To: <201905070531.x475VuIY010069@gndrsh.dnsmgr.net> From: Dmitry Chagin Date: Tue, 7 May 2019 08:45:44 +0300 Message-ID: Subject: Re: svn commit: r347218 - head/sys/compat/linsysfs To: rgrimes@freebsd.org Cc: Dmitry Chagin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 7A59474E01 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.84 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.84)[-0.839,0]; TAGGED_FROM(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 May 2019 07:16:19 -0000 =D0=B2=D1=82, 7 =D0=BC=D0=B0=D1=8F 2019 =D0=B3. =D0=B2 08:32, Rodney W. Gri= mes : > > Author: dchagin > > Date: Tue May 7 05:08:13 2019 > > New Revision: 347218 > > URL: https://svnweb.freebsd.org/changeset/base/347218 > > > > Log: > > Remove wrong copyright line. Discussed with Carlos Neira. > > > > Reported by: Rodney W. Grimes > normally just use a committers username, aka rgrimes or rgrimes@ > for these types of things. > > ah, I see only: Rodney W. Grimes > > MFC after: 2 weeks > > Differential Revision: https://reviews.freebsd.org/D13656 > > Hang on, now you removed his copyright? > I see he said that was ok, but that was not the desired intent here. > It would of been fine to have the copyright read: > > * Copyright (c) 2006 IronPort Systems > * All rights reserved. > * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com > > As a heads up to other committers you should never insert your > copyright between another copyright and the "All rights reserved." text, > if you wish to assert the all rights reserved you should duplicate > it like: > > * Copyright (c) 2006 IronPort Systems > * All rights reserved. > * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com > * All rights reserved. > > preferably on the line with your copyright as in: > * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com All rights > reserved. > > But if at all possible it would be best if we could not add any > more of these, and remove them when possible. > > and that actually I did. thanks > For those wishing to save space the (c) is unneeded when you > spell out the word "Copyright". > > > > > Modified: > > head/sys/compat/linsysfs/linsysfs.c > > > > Modified: head/sys/compat/linsysfs/linsysfs.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- head/sys/compat/linsysfs/linsysfs.c Tue May 7 01:27:23 2019 > (r347217) > > +++ head/sys/compat/linsysfs/linsysfs.c Tue May 7 05:08:13 2019 > (r347218) > > @@ -2,7 +2,6 @@ > > * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > * > > * Copyright (c) 2006 IronPort Systems > > - * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com > > * All rights reserved. > > * > > * Redistribution and use in source and binary forms, with or without > > > > > > -- > Rod Grimes > rgrimes@freebsd.org >