From owner-svn-src-all@FreeBSD.ORG Tue Mar 3 19:49:13 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4CF7106564A for ; Tue, 3 Mar 2009 19:49:13 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.26]) by mx1.freebsd.org (Postfix) with ESMTP id 561098FC18 for ; Tue, 3 Mar 2009 19:49:12 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by qw-out-2122.google.com with SMTP id 3so2382243qwe.7 for ; Tue, 03 Mar 2009 11:49:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=Zh33woNqK+dc5EL8RFfyNAPX8K0D9acuNUAnC8w9ozY=; b=i4TBHX6JhinDcjzIQnsILtvbTOstH0JDO2d991q4p18JBVcw2j1h0ku0llDmdyvZ/C 2eNdwK3lPQX2nDDrvx5nYpWS2FHbt/rG3i2JSJOOiU9ta8Cn6dWA2Lz984qiug3GZzV4 NycZdBM16qsoxoFhER1nGOS6+/DQSVloLBRg8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=TH08AJTZEkgL8lrPSgyQZG2mKGXv6lsVqUIVNlE8n/iFtV+E/5ZRqpJMLOjnj2jmKK HHz81J+cV7DBLm5OcKrmVX0OWSVAftQiL/iZK9+ugveLAVJFby702JpD3dKmRLFYfXzQ o0l2YZ+D0SUZ2X6ZRT/r3siNNMBd4RGdOavdA= Received: by 10.224.74.9 with SMTP id s9mr10177063qaj.321.1236108075346; Tue, 03 Mar 2009 11:21:15 -0800 (PST) Received: from kan.dnsalias.net (c-98-217-224-113.hsd1.ma.comcast.net [98.217.224.113]) by mx.google.com with ESMTPS id 8sm235906qwj.46.2009.03.03.11.21.11 (version=SSLv3 cipher=RC4-MD5); Tue, 03 Mar 2009 11:21:13 -0800 (PST) Date: Tue, 3 Mar 2009 14:21:06 -0500 From: Alexander Kabaev To: Ed Schouten Message-ID: <20090303142106.0ee73d35@kan.dnsalias.net> In-Reply-To: <200903031847.n23IlX7N018454@svn.freebsd.org> References: <200903031847.n23IlX7N018454@svn.freebsd.org> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.11; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/XA3xMmQCB9EVQono.sATloK"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189315 - in head/sys/netgraph: . atm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2009 19:49:14 -0000 --Sig_/XA3xMmQCB9EVQono.sATloK Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 3 Mar 2009 18:47:33 +0000 (UTC) Ed Schouten wrote: > Author: ed > Date: Tue Mar 3 18:47:33 2009 > New Revision: 189315 > URL: http://svn.freebsd.org/changeset/base/189315 >=20 > Log: > Make Netgraph compile with Clang. > =20 > Clang disallows structs with variable length arrays to be nested > inside other structs, because this is in violation with ISO C99. Even > though we can keep bugging the LLVM folks about this issue, we'd > better just fix our code to not do this. This code seems to be the > only code in the entire source tree that does this. > =20 > I haven't tested this patch by using the kernel modules in > question, but Diane Bruce and I have compared disassembled versions > of these kernel modules. We would have expected them to be exactly > the same, but due to randomness in the register allocator and > reordering of instructions, there were some minor differences. > =20 > Approved by: julian >=20 > Modified: > head/sys/netgraph/atm/ng_ccatm.h > head/sys/netgraph/ng_pppoe.c > head/sys/netgraph/ng_pppoe.h Hi, I hope I am not the only one to see this as a code regression from the code readability viewpoint. I think obfuscation of our sources just to bow to yet another head-strong compiler should stop. If LLVM cannot parse common code constructs, LLVM is NOT suitable for our kernel no matter how many paragraphs of language-lawyer-speak they use to justify it.=20 --=20 Alexander Kabaev --Sig_/XA3xMmQCB9EVQono.sATloK Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFJrYMiQ6z1jMm+XZYRAm/UAJ9WsPSwAv+tXFp087qPla64M+IXbgCgg9iN GxYKPlhQKOsp9fZG1eGQXIM= =/7ko -----END PGP SIGNATURE----- --Sig_/XA3xMmQCB9EVQono.sATloK--