From owner-freebsd-bugs@FreeBSD.ORG Tue Jun 14 10:30:12 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0B5B106566C for ; Tue, 14 Jun 2011 10:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 639F18FC17 for ; Tue, 14 Jun 2011 10:30:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5EAUCus023681 for ; Tue, 14 Jun 2011 10:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5EAUCOc023674; Tue, 14 Jun 2011 10:30:12 GMT (envelope-from gnats) Resent-Date: Tue, 14 Jun 2011 10:30:12 GMT Resent-Message-Id: <201106141030.p5EAUCOc023674@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Petr Salinger Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52F84106564A for ; Tue, 14 Jun 2011 10:24:19 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 42BBD8FC08 for ; Tue, 14 Jun 2011 10:24:19 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p5EAOImt037445 for ; Tue, 14 Jun 2011 10:24:18 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p5EAOIQ1037415; Tue, 14 Jun 2011 10:24:18 GMT (envelope-from nobody) Message-Id: <201106141024.p5EAOIQ1037415@red.freebsd.org> Date: Tue, 14 Jun 2011 10:24:18 GMT From: Petr Salinger To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/157871: [patch] linprocfs: cmdline/environ for kernel-only processes returns EFAULT instead of empty string X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2011 10:30:12 -0000 >Number: 157871 >Category: kern >Synopsis: [patch] linprocfs: cmdline/environ for kernel-only processes returns EFAULT instead of empty string >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jun 14 10:30:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Petr Salinger >Release: 8.2 >Organization: >Environment: GNU/kFreeBSD debian 8.2-1-amd64 >Description: Between 8.1 and 8.2 have been in linprocfs added support for $PID/environ and changed implementation of $PID/cmdline. Now it for kernel-only processes returns EFAULT instead of empty string. It breaks at least "pstree -a". See Debian GNU/kFreeBSD bug #630104 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=630104 >How-To-Repeat: >Fix: --- a/sys/compat/linprocfs/linprocfs.c +++ b/sys/compat/linprocfs/linprocfs.c @@ -1044,6 +1044,10 @@ PROC_UNLOCK(p); return (ret); } + if (p->p_flag & P_KTHREAD) { + PROC_UNLOCK(p); + return (0); + } if (p->p_args != NULL) { sbuf_bcpy(sb, p->p_args->ar_args, p->p_args->ar_length); PROC_UNLOCK(p); @@ -1068,6 +1072,10 @@ PROC_UNLOCK(p); return (ret); } + if (p->p_flag & P_KTHREAD) { + PROC_UNLOCK(p); + return (0); + } PROC_UNLOCK(p); ret = linprocfs_doargv(td, p, sb, ps_string_env); >Release-Note: >Audit-Trail: >Unformatted: