From owner-freebsd-current Sat Jun 15 23:56:24 2002 Delivered-To: freebsd-current@freebsd.org Received: from dilbert.robbins.dropbear.id.au (219.b.003.mel.iprimus.net.au [210.50.32.219]) by hub.freebsd.org (Postfix) with ESMTP id F09D537B401; Sat, 15 Jun 2002 23:56:19 -0700 (PDT) Received: from dilbert.robbins.dropbear.id.au (tim@localhost [127.0.0.1]) by dilbert.robbins.dropbear.id.au (8.12.3/8.12.3) with ESMTP id g5G6uDY2010105; Sun, 16 Jun 2002 16:56:13 +1000 (EST) (envelope-from tim@dilbert.robbins.dropbear.id.au) Received: (from tim@localhost) by dilbert.robbins.dropbear.id.au (8.12.3/8.12.3/Submit) id g5G6swEW010100; Sun, 16 Jun 2002 16:54:58 +1000 (EST) Date: Sun, 16 Jun 2002 16:54:58 +1000 From: Tim Robbins To: Joe Marcus Clarke Cc: dougb@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: [PATCH] sed is broken in -CURRENT Message-ID: <20020616165458.A10075@dilbert.robbins.dropbear.id.au> References: <1024202502.81450.13.camel@shumai.marcuscom.com> <3D0C30CA.216164DE@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <3D0C30CA.216164DE@FreeBSD.org>; from DougB@FreeBSD.ORG on Sat, Jun 15, 2002 at 11:31:38PM -0700 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jun 15, 2002 at 11:31:38PM -0700, Doug Barton wrote: > Joe Marcus Clarke wrote: > > > > After the recent round of -i fixes to sed, certain ports will no longer > > make configure (gaim being a prime example). The problem is that > > mf_fgets() is unnecessarily overwriting sp->len. The attached patch > > corrects the problem while still allowing -i to work on multiple files. > > > > As a ports committer, I can't do anything but let you guys (and gals) > > know. > > Just like any other user, you can file a PR. And given that you're a > committer, you can then assign it to whoever broke the things your patch > fixes. There is already a PR open for this issue: bin/39310 . It is assigned to sobomax becauses his streamlining of the file processing code inadvertently caused the incorrect behaviour. Such are the perils of using -CURRENT for anything but development and testing :) Tim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message