From owner-dev-commits-src-main@freebsd.org Sat May 15 20:19:50 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8182264EF15; Sat, 15 May 2021 20:19:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FjGw55x1Tz3n3Y; Sat, 15 May 2021 20:19:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 14FKEVwT047967 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 15 May 2021 23:14:34 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 14FKEVwT047967 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 14FKEV4O047966; Sat, 15 May 2021 23:14:31 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 15 May 2021 23:14:31 +0300 From: Konstantin Belousov To: Lutz Donnerhacke Cc: Lutz Donnerhacke , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup Message-ID: References: <202105150701.14F717lf084359@gitrepo.freebsd.org> <20210515195812.GB17734@belenus.iks-jena.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210515195812.GB17734@belenus.iks-jena.de> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4FjGw55x1Tz3n3Y X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 May 2021 20:19:50 -0000 On Sat, May 15, 2021 at 09:58:12PM +0200, Lutz Donnerhacke wrote: > On Sat, May 15, 2021 at 10:41:53PM +0300, Konstantin Belousov wrote: > > On Sat, May 15, 2021 at 07:01:07AM +0000, Lutz Donnerhacke wrote: > > > @@ -285,21 +283,20 @@ static int UdpAliasOut(struct libalias *, struct ip *, int, int create); > > > static int TcpAliasIn(struct libalias *, struct ip *); > > > static int TcpAliasOut(struct libalias *, struct ip *, int, int create); > > > > > > -static int > > > -IcmpAliasIn1(struct libalias *la, struct ip *pip) > > > -{ > > > - > > > - LIBALIAS_LOCK_ASSERT(la); > > > /* > > > De-alias incoming echo and timestamp replies. > > > Alias incoming echo and timestamp requests. > > > */ > > > +static int > > > +IcmpAliasIn1(struct libalias *la, struct ip *pip) > > > +{ > > > + LIBALIAS_LOCK_ASSERT(la); > > > struct alias_link *lnk; > > > struct icmp *ic; > > And this is not in style. Declarations must precede executable statements, > > even asserts. > > Of course it was a style commit. > > + /* > + De-alias incoming echo and timestamp replies. > + Alias incoming echo and timestamp requests. > + */ > static int > IcmpAliasIn1(struct libalias *la, struct ip *pip) > { > - > LIBALIAS_LOCK_ASSERT(la); > - /* > - De-alias incoming echo and timestamp replies. > - Alias incoming echo and timestamp requests. > - */ > struct alias_link *lnk; I do not understand what are you trying to say.