From owner-cvs-src@FreeBSD.ORG Sat Oct 27 09:33:50 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4932B16A41A; Sat, 27 Oct 2007 09:33:50 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id B03DB13C49D; Sat, 27 Oct 2007 09:33:49 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9R9Xc12053752; Sat, 27 Oct 2007 13:33:38 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1193477618; bh=T+W/HAWleuONp0rWxoKnCeXNednJVVI15Yn424h xXOc=; l=941; h=Date:From:To:Subject:Message-ID:Mail-Followup-To: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:User-Agent; b=oqMaj7E+1iDye+0Lt/jofxvXY050//IvX0AN6wx9 oHeE9JeharrxaHVTjMBC6zSuT5UvKBQPAxMRx8o87oWdvEVy4q8uX4bEGXINOaFq6Bs JhEcD6JcC+yjoO7oBkBXYZr5bihqkRlraHDmQIBa6dy7aDIU9W5hvVkuhrif6Idc= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9R9XbDE053749; Sat, 27 Oct 2007 13:33:37 +0400 (MSD) (envelope-from ache) Date: Sat, 27 Oct 2007 13:33:36 +0400 From: Andrey Chernov To: Rong-en Fan , Scott Long , John Baldwin , src-committers@freebsd.org, d@delphij.net, Robert Watson , imp@freebsd.org, cvs-src@freebsd.org Message-ID: <20071027093336.GA53565@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Rong-en Fan , Scott Long , John Baldwin , src-committers@freebsd.org, d@delphij.net, Robert Watson , imp@freebsd.org, cvs-src@freebsd.org References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <20071025233536.B99770@fledge.watson.org> <472120E8.90504@samsco.org> <200710261144.34645.jhb@freebsd.org> <472217C2.8020800@samsco.org> <6eb82e0710260954m73b3f17bq2c72a4cdb597640e@mail.gmail.com> <6eb82e0710270130o5557efew95f62aef8035d209@mail.gmail.com> <20071027092213.GA53271@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071027092213.GA53271@nagual.pp.ru> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2007 09:33:50 -0000 On Sat, Oct 27, 2007 at 01:22:13PM +0400, Andrey Chernov wrote: > > After some tests, the patch is at > > > > http://people.freebsd.org/~rafan/ctype-abi-fix-6.diff > > > > Let me describe this patch in more details. Fist, we actually > > compile those inline functions as real functions in > > lib/libc/locale/nomacro.c if _EXTERNAL_CTYPE_INLINES_ is defined. > > I make 4 inline functions that use the __mb_sb_limit symbol, > > which break the compatibility, always compiled as real functions. > > I also considered that moving those inlined function in another > > C file, but I think it would make the source codes diverse > > among 6 and 7/8. > > As a small improvement, we can skip __isctype() from this list too and > just hardcode 128 there, i.e.: return (_c < 0 || _c >= 128) ... > since default locale never define anything above 128. See _ctype.h patch just committed in -current -- http://ache.pp.ru/