From owner-svn-src-all@FreeBSD.ORG Tue May 18 22:55:08 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 727F61065670; Tue, 18 May 2010 22:55:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3]) by mx1.freebsd.org (Postfix) with ESMTP id 05AA08FC12; Tue, 18 May 2010 22:55:08 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 0508241C796; Wed, 19 May 2010 00:55:07 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id ZJX+saodK586; Wed, 19 May 2010 00:55:06 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id EFF2C41C795; Wed, 19 May 2010 00:55:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id C87D24448EC; Tue, 18 May 2010 22:53:27 +0000 (UTC) Date: Tue, 18 May 2010 22:53:27 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Pyun YongHyeon In-Reply-To: <20100518171315.GA5968@michelle.cdnetworks.com> Message-ID: <20100518224555.G23815@maildrop.int.zabbadoz.net> References: <201005101714.o4AHEFuu015079@svn.freebsd.org> <20100518032628.S23815@maildrop.int.zabbadoz.net> <20100518171315.GA5968@michelle.cdnetworks.com> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pyun YongHyeon Subject: Re: svn commit: r207851 - head/sys/dev/sge X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2010 22:55:08 -0000 On Tue, 18 May 2010, Pyun YongHyeon wrote: > On Tue, May 18, 2010 at 03:27:33AM +0000, Bjoern A. Zeeb wrote: >> On Mon, 10 May 2010, Pyun YongHyeon wrote: >> >>> Author: yongari >>> Date: Mon May 10 17:14:14 2010 >>> New Revision: 207851 >>> URL: http://svn.freebsd.org/changeset/base/207851 >>> >>> Log: >>> Implement TSO and TSO over VLAN. Increase number of allowed >>> fragmentation of mbuf chain to 32 from 16 because TSO can send 64KB >>> sized packet which in turn requires long list of mbuf chain. Due to >>> lack of documentation, I'm not sure whether driver have to pull up >>> ethernet/IP/TCP header with options to make controller work but >>> driver have to parse TCP header to update pseudo TCP checksum >>> anyway. The controller expects pseudo TCP checksum computed by >>> upper stack and the checksum should follow the MS NDIS >>> specification to make TSO work. >>> >>> Tested by: xclin cs dot nctu dot edu dot tw > >> >> This brings in INET as a dependency for the driver and fails on my >> nooptions INET >> nooptions INET6 >> kernels (in_pseudo()). >> > > AFAIK sge(4) is not the only driver that has INET dependency. I > think we need IPv6 offloading framework(checksum offloading, TSO4 There is no checksum on IPv6. > and TSO6) before removing INET dependency in various drivers. > Most recent ethernet controllers support IPv6 offloading and > FreeBSD still lacks these nice features. This is true, but we should (still) fix this and work on a better solution. You may remember that I tried to get this discussion started twice during the last 12 months. First time after I added the inet depency in sys/conf/files for all the other drivers that have the same problem(s). I will be very happy to chat with you and np@ and maybe tuexen@ for SCTP and Drew and Jack again to get this all sorted out. /bz -- Bjoern A. Zeeb (from 21) Micky Rosa: But as we've all said, this game is about the past and the future, and tonight we forget about the past. We just focus on the future.