From owner-svn-ports-all@freebsd.org Mon Jan 15 20:40:12 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D98E8E755E4; Mon, 15 Jan 2018 20:40:12 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B324E6CD58; Mon, 15 Jan 2018 20:40:12 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E5003162BE; Mon, 15 Jan 2018 20:40:11 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w0FKeBWK048701; Mon, 15 Jan 2018 20:40:11 GMT (envelope-from kevans@FreeBSD.org) Received: (from kevans@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w0FKeBKx048699; Mon, 15 Jan 2018 20:40:11 GMT (envelope-from kevans@FreeBSD.org) Message-Id: <201801152040.w0FKeBKx048699@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: kevans set sender to kevans@FreeBSD.org using -f From: Kyle Evans Date: Mon, 15 Jan 2018 20:40:11 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r459112 - in head/devel/bossa: . files X-SVN-Group: ports-head X-SVN-Commit-Author: kevans X-SVN-Commit-Paths: in head/devel/bossa: . files X-SVN-Commit-Revision: 459112 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 20:40:13 -0000 Author: kevans (src committer) Date: Mon Jan 15 20:40:11 2018 New Revision: 459112 URL: https://svnweb.freebsd.org/changeset/ports/459112 Log: devel/bossa: Fix build after recent Clang update on -HEAD Clang 6 caught a bogus comparison that was not previously caught; fix the build by correcting the comparison to correctly dereference the `char *` before comparing it with '\0'. PORTREVISION bumped because the comparison was erroneous and still successfully built everywhere but -HEAD. This patch is effectively from upstream. It will go away with the update to BOSSA 1.8, which requires a little more testing still. Approved by: antoine Added: head/devel/bossa/files/patch-src_Command.cpp (contents, props changed) Modified: head/devel/bossa/Makefile Modified: head/devel/bossa/Makefile ============================================================================== --- head/devel/bossa/Makefile Mon Jan 15 20:13:22 2018 (r459111) +++ head/devel/bossa/Makefile Mon Jan 15 20:40:11 2018 (r459112) @@ -2,7 +2,7 @@ PORTNAME= bossa PORTVERSION= 1.7.0 -PORTREVISION= 4 +PORTREVISION= 5 CATEGORIES= devel MAINTAINER= kevans@FreeBSD.org Added: head/devel/bossa/files/patch-src_Command.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/bossa/files/patch-src_Command.cpp Mon Jan 15 20:40:11 2018 (r459112) @@ -0,0 +1,20 @@ +--- src/Command.cpp.orig 2018-01-15 20:28:09 UTC ++++ src/Command.cpp +@@ -674,7 +674,7 @@ CommandMwb::invoke(char* argv[], int argc) + char* input = readline("? "); + if (!input) + return; +- if (input == '\0' || ++ if (*input == '\0' || + !argUint32(input, &value)) + { + free(input); +@@ -777,7 +777,7 @@ CommandMww::invoke(char* argv[], int argc) + char* input = readline("? "); + if (!input) + return; +- if (input == '\0' || ++ if (*input == '\0' || + !argUint32(input, &value)) + { + free(input);