From nobody Wed Nov 15 21:59:46 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SVxss6gwkz50ndY for ; Wed, 15 Nov 2023 22:00:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SVxss4j3yz3FTt for ; Wed, 15 Nov 2023 22:00:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-50970c2115eso181861e87.1 for ; Wed, 15 Nov 2023 14:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1700085599; x=1700690399; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UKG7waAEJ0xqWSnVrWVhrN3uuI4hHzqHFT0KWKOSGtg=; b=eAy7vBdEdFoGEF8/a/+/7IjtxHKTKH9r6F8oiYgvgBpSliJSu4IuYwcYUotAX/r/qr jcDKJTh9YhJpzYIG63VbtmmLvAr3FPG8ODQIeWka82djz7ngDd4J28eQAvilOCitZwV5 uDPfZljH6M3oNXFHmECSRkl9pdc3v8zznUtuCvxO7dOKF3t6jTAYA5dQTdh3AoSXKE9W 1CrXF62HxIbIEGheRFlx6CMs4mRfCAx/v2xMok9kkFzMML0nKU6OB38oOH6Npl7DIHTx Dk6W3MkLKR9hwLxxaFF9ieI7jlvOby6HfHebC0dIRc/1st0aXG3ykvaVJpDjB2kF+Jvl MuuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700085599; x=1700690399; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UKG7waAEJ0xqWSnVrWVhrN3uuI4hHzqHFT0KWKOSGtg=; b=jnIGn0TdR9QuIn9Lb64F2WYsCgGrHVJrcHtltJDyhfAs/lvOsIdWgz606b5Fd1TkL4 GXY2mQA7l+fJkW3sDscXs43BdUqV0UXrJ006iMT5gd7IMV1MbeFRn9En5xh4TKbPX4xH als6uX6r/A5hs6w4n5HeCiimpLk+3rwnatmA7vXbd3SY+r61abhchytc6K1kyj6aQoZj zow18d//y6d7DLdVBB+XkCRKHrZ6zxrHkF5TRerqQoBqmv3hRmYg5jR6a0+SODrsgf2a wCiy9rBLvayy/exh6vxsy4iHFSFc/Aur0OucdaeyX3hTww65ZRn9DpXMNTj+wH+X/8VA noWw== X-Gm-Message-State: AOJu0Yx22MP7uRinpUZgqpcovbz0YUg4WVypDMi1+WZpI7EXJYQTP3BQ vuAd0afE4uprBNfwS9gS5lLGvYpA4wtHGEVoXuPMlA== X-Google-Smtp-Source: AGHT+IFZIlljXTbmPcc6vb40v2AugPuP5fwHKVBD355bnI8Mp/bPqM9e/71DguUzbAgHMOGdt3KBa1Snzsi2xz8UZps= X-Received: by 2002:a05:6512:60d:b0:503:3808:389a with SMTP id b13-20020a056512060d00b005033808389amr8108814lfe.11.1700085598338; Wed, 15 Nov 2023 13:59:58 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202311140451.3AE4p5AR014207@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 15 Nov 2023 14:59:46 -0700 Message-ID: Subject: Re: git: 3fd60a6b73ac - main - awk: Merge upstream 2nd Edition Awk Book To: Jessica Clarke Cc: Warner Losh , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="0000000000002d5458060a380609" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4SVxss4j3yz3FTt --0000000000002d5458060a380609 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 15, 2023 at 9:52=E2=80=AFAM Jessica Clarke = wrote: > On 14 Nov 2023, at 04:51, Warner Losh wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D3fd60a6b73ac01a72df89751f173970= fae4cae73 > > > > commit 3fd60a6b73ac01a72df89751f173970fae4cae73 > > Merge: 194df014feeb 2e406c584fe4 > > Author: Warner Losh > > AuthorDate: 2023-11-02 16:32:01 +0000 > > Commit: Warner Losh > > CommitDate: 2023-11-14 04:49:34 +0000 > > > > awk: Merge upstream 2nd Edition Awk Book > > > > Merge in the November 2nd, 2023 version of one true awk. > > > > This brings in Unicode support, CSV support and a number of bug fixe= s. > > > > Sponsored by: Netflix > > Reviewed by: delphij > > Differential Revision: https://reviews.freebsd.org/D42447 > > This seems to have broken the GitHub CI for cross-building; contrast: > > https://github.com/freebsd/freebsd-src/actions/runs/6859373313 > > with: > > https://github.com/freebsd/freebsd-src/actions/runs/6859316228 > > Has this broken makeobjops.awk somehow? If so it should be reproducible > on FreeBSD with BOOTSTRAP_ALL_TOOLS=3D1, or by rebuilding on an updated > system. Cross-building will just show it first because we always > bootstrap awk there, like many other tools. > It worked when it was the system awk for me... But that might not be the most helpful observation. Why didn't it work for you/github's ci runs? makeobjops.awk doesn't have any of the issues that I know are minor changes in awk. I'll add it to the list of things to look into, though. I also broke the Jenkins CI run, but not 'make check' for reasons I don't understand. Warner --0000000000002d5458060a380609 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Nov 15, 2023 at 9:52=E2=80=AF= AM Jessica Clarke <jrtc27@freebsd.= org> wrote:
On 14 Nov 2023, at 04:51, Warner Losh <imp@FreeBSD.org> wrote:
>
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D3fd60a6b73ac01a72df89751f173970fae4cae73<= /a>
>
> commit 3fd60a6b73ac01a72df89751f173970fae4cae73
> Merge: 194df014feeb 2e406c584fe4
> Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2023-11-02 16:32:01 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2023-11-14 04:49:34 +0000
>
>=C2=A0 =C2=A0 awk: Merge upstream 2nd Edition Awk Book
>
>=C2=A0 =C2=A0 Merge in the November 2nd, 2023 version of one true awk.<= br> >
>=C2=A0 =C2=A0 This brings in Unicode support, CSV support and a number = of bug fixes.
>
>=C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Net= flix
>=C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 del= phij
>=C2=A0 =C2=A0 Differential Revision:=C2=A0
https://reviews.fre= ebsd.org/D42447

This seems to have broken the GitHub CI for cross-building; contrast:

https://github.com/freebsd/freebsd-src= /actions/runs/6859373313

with:

https://github.com/freebsd/freebsd-src= /actions/runs/6859316228

Has this broken makeobjops.awk somehow? If so it should be reproducible
on FreeBSD with BOOTSTRAP_ALL_TOOLS=3D1, or by rebuilding on an updated
system. Cross-building will just show it first because we always
bootstrap awk there, like many other tools.

=
It worked when it was the system awk for me...=C2=A0 But that might no= t be the most
helpful observation. Why didn't it work for you= /github's ci runs?

makeobjops.awk=C2=A0doesn&#= 39;t have any of the issues that I know are minor changes
in awk.= I'll add it to the list of things to look into, though.

=
I also broke the Jenkins CI run, but not 'make check' fo= r reasons I don't
understand.

Warner=


--0000000000002d5458060a380609--