From owner-svn-src-head@FreeBSD.ORG  Sun Apr 13 20:12:21 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C937FBA8;
 Sun, 13 Apr 2014 20:12:21 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B5AB711CA;
 Sun, 13 Apr 2014 20:12:21 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s3DKCLTb019510;
 Sun, 13 Apr 2014 20:12:21 GMT
 (envelope-from brueffer@svn.freebsd.org)
Received: (from brueffer@localhost)
 by svn.freebsd.org (8.14.8/8.14.8/Submit) id s3DKCLmf019509;
 Sun, 13 Apr 2014 20:12:21 GMT
 (envelope-from brueffer@svn.freebsd.org)
Message-Id: <201404132012.s3DKCLmf019509@svn.freebsd.org>
From: Christian Brueffer <brueffer@FreeBSD.org>
Date: Sun, 13 Apr 2014 20:12:21 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r264419 - head/usr.bin/ldd
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Apr 2014 20:12:21 -0000

Author: brueffer
Date: Sun Apr 13 20:12:21 2014
New Revision: 264419
URL: http://svnweb.freebsd.org/changeset/base/264419

Log:
  Avoid double close() of a file descriptor.
  
  CID:		1006089
  Found with:	Coverity Prevent(tm)
  MFC after:	1 week

Modified:
  head/usr.bin/ldd/sods.c

Modified: head/usr.bin/ldd/sods.c
==============================================================================
--- head/usr.bin/ldd/sods.c	Sun Apr 13 19:48:51 2014	(r264418)
+++ head/usr.bin/ldd/sods.c	Sun Apr 13 20:12:21 2014	(r264419)
@@ -204,7 +204,6 @@ dump_file(const char *fname)
 	warnx("%s: this is an ELF program; use objdump to examine", fname);
 	++error_count;
 	munmap(objbase, sb.st_size);
-	close(fd);
 	return;
     }