From owner-svn-src-head@FreeBSD.ORG  Fri Aug 24 21:45:53 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4E83B1065673;
	Fri, 24 Aug 2012 21:45:53 +0000 (UTC)
	(envelope-from bapt@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 3A3638FC14;
	Fri, 24 Aug 2012 21:45:53 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q7OLjrT3010297;
	Fri, 24 Aug 2012 21:45:53 GMT (envelope-from bapt@svn.freebsd.org)
Received: (from bapt@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id q7OLjrqB010295;
	Fri, 24 Aug 2012 21:45:53 GMT (envelope-from bapt@svn.freebsd.org)
Message-Id: <201208242145.q7OLjrqB010295@svn.freebsd.org>
From: Baptiste Daroussin <bapt@FreeBSD.org>
Date: Fri, 24 Aug 2012 21:45:53 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r239664 - head/usr.sbin/pkg
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Aug 2012 21:45:53 -0000

Author: bapt
Date: Fri Aug 24 21:45:52 2012
New Revision: 239664
URL: http://svn.freebsd.org/changeset/base/239664

Log:
  Fix confirmation logic when detecting a tty
  
  Reported by:	mjg

Modified:
  head/usr.sbin/pkg/pkg.c

Modified: head/usr.sbin/pkg/pkg.c
==============================================================================
--- head/usr.sbin/pkg/pkg.c	Fri Aug 24 21:08:56 2012	(r239663)
+++ head/usr.sbin/pkg/pkg.c	Fri Aug 24 21:45:52 2012	(r239664)
@@ -427,10 +427,10 @@ main(__unused int argc, char *argv[])
 		 */
 		if (getenv("ASSUME_ALWAYS_YES") == NULL) {
 			printf("%s", confirmation_message);
-			if (isatty(fileno(stdin)) &&
-			    pkg_query_yes_no() == 0)
+			if (!isatty(fileno(stdin)))
 				exit(EXIT_FAILURE);
-			else
+
+			if (pkg_query_yes_no() == 0)
 				exit(EXIT_FAILURE);
 		}
 		if (bootstrap_pkg() != 0)