From owner-p4-projects@FreeBSD.ORG  Wed Jun  6 00:26:03 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 493FC16A46C; Wed,  6 Jun 2007 00:26:03 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E204716A400;
	Wed,  6 Jun 2007 00:26:02 +0000 (UTC) (envelope-from rpaulo@fnop.net)
Received: from core.fnop.net (mx.fnop.net [82.102.11.82])
	by mx1.freebsd.org (Postfix) with ESMTP id 5FAFB13C465;
	Wed,  6 Jun 2007 00:26:02 +0000 (UTC) (envelope-from rpaulo@fnop.net)
Received: from core.fnop.net (mx.fnop.net [82.102.11.82])
	by core.fnop.net (Postfix) with ESMTP id 1750F690AED;
	Wed,  6 Jun 2007 01:23:45 +0100 (WEST)
Received: by core.fnop.net (Postfix, from userid 1015)
	id CA69C690AFA; Wed,  6 Jun 2007 01:23:44 +0100 (WEST)
X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net
X-Spam-Level: 
X-Spam-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00,
	FORGED_RCVD_HELO,RCVD_IN_SORBS_DUL autolearn=no version=3.1.7
Received: from epsilon.local.fnop.net (87-196-25-235.net.novis.pt
	[87.196.25.235])
	by core.fnop.net (Postfix) with ESMTP id 23C8D690AED;
	Wed,  6 Jun 2007 01:23:44 +0100 (WEST)
Date: Wed, 06 Jun 2007 01:25:56 +0100
Message-ID: <86myzeq67f.wl%rpaulo@fnop.net>
From: Rui Paulo <rpaulo@fnop.net>
To: attilio@FreeBSD.org
In-Reply-To: <4661BFD0.1080107@FreeBSD.org>
References: <200706021756.l52Huq9A049371@repoman.freebsd.org>
	<4661BFD0.1080107@FreeBSD.org>
User-Agent: Wanderlust/2.15.5 (Almost Unreal) Emacs/21.3 Mule/5.0 (SAKAKI)
X-cite-me: rpaulo
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
X-Virus-Scanned: ClamAV using ClamSMTP
Cc: Perforce Change Reviews <perforce@FreeBSD.org>,
	Rui Paulo <rpaulo@FreeBSD.org>
Subject: Re: PERFORCE change 120788 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jun 2007 00:26:03 -0000

At Sat, 02 Jun 2007 21:06:56 +0200,
Attilio Rao wrote:
> 
> Rui Paulo wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=120788
> > Change 120788 by rpaulo@rpaulo_epsilon on 2007/06/02 17:55:58
> > 	Add locking.
> > Affected files ...
> 
> Ah, but it seems you don't use a "fast" interrupt handler, so you
> should not use a spinlock... spinlocks should only be used in fast
> interrupt handlers, otherwise you bring up all the disvantages of the
> model...

Could you please comment on this?

If I'm not doing something wrong, I need to use spin locks on my
interrupt handler, or else witness_checkorder will complain with
"blockable sleep lock".

Note that I'm using FILTERs.

Thanks in advance.
--
Rui Paulo