From owner-svn-src-head@FreeBSD.ORG Fri Dec 21 04:47:08 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 67CD476F; Fri, 21 Dec 2012 04:47:08 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-ie0-f178.google.com (mail-ie0-f178.google.com [209.85.223.178]) by mx1.freebsd.org (Postfix) with ESMTP id F351A8FC13; Fri, 21 Dec 2012 04:47:07 +0000 (UTC) Received: by mail-ie0-f178.google.com with SMTP id c12so5614786ieb.37 for ; Thu, 20 Dec 2012 20:47:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3pNN1SvxAiZR/Ym8gWowrdmnar+otmmLtrg3DneL8gY=; b=TMw0+xtLGiRsull9SIMOV0t6hROuJjB0CKuBZZBxb0B12HniKCntyvE/B/QXbHBs/J 1bzNb+8yebDaSRQKdvGXRkpbV13vB1iokYcYDObUZGH4NAxgqffXQEf4mcyp/An1n4Xq hP3d42NKS5EH8vUD8olonMrp0biWPbHHlr1Oa493E6/kwF8QLmkc9oVtbpGKcRoNmoyw 0JMiHaQeKafynxIT+HlhGxDQmaPJZprrXOhWx4J5Zy3264orBDXLsV+ibVKLaEL7cgN/ Zhv4dtVMp+qjY42lmoL/Jp8xVkdgwUmD2mQHGoTrckx/pskmiQG8yajRj7nBkdQ9XlGX OHKw== MIME-Version: 1.0 Received: by 10.43.17.199 with SMTP id qd7mr6221242icb.52.1356065227186; Thu, 20 Dec 2012 20:47:07 -0800 (PST) Received: by 10.43.112.194 with HTTP; Thu, 20 Dec 2012 20:47:07 -0800 (PST) In-Reply-To: References: <201212210131.qBL1Vuu4062307@svn.freebsd.org> Date: Thu, 20 Dec 2012 20:47:07 -0800 Message-ID: Subject: Re: svn commit: r244526 - head/usr.sbin/mptable From: Neel Natu To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Neel Natu X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2012 04:47:08 -0000 Hi Garrett, On Thu, Dec 20, 2012 at 6:07 PM, Garrett Cooper wrote: > On Thu, Dec 20, 2012 at 5:31 PM, Neel Natu wrote: >> Author: neel >> Date: Fri Dec 21 01:31:56 2012 >> New Revision: 244526 >> URL: http://svnweb.freebsd.org/changeset/base/244526 >> >> Log: >> The MPtable specification allows for an 8-bit "BUS ID" and "I/O APIC ID". >> >> Since the 'busses[]' and 'apics[]' arrays are indexed by these 8-bit IDs >> make sure that they have enough space to accomodate up to 256 entries. >> >> Submitted by: Ravi Shamanna >> Obtained from: NetApp >> >> Modified: >> head/usr.sbin/mptable/mptable.c >> >> Modified: head/usr.sbin/mptable/mptable.c >> ============================================================================== >> --- head/usr.sbin/mptable/mptable.c Fri Dec 21 01:19:48 2012 (r244525) >> +++ head/usr.sbin/mptable/mptable.c Fri Dec 21 01:31:56 2012 (r244526) >> @@ -270,8 +270,8 @@ static void pnstr( char* s, int c ); >> /* global data */ >> static int pfd; /* physical /dev/mem fd */ >> >> -static int busses[16]; >> -static int apics[16]; >> +static int busses[256]; >> +static int apics[256]; >> >> static int ncpu; >> static int nbus; >> @@ -711,7 +711,7 @@ MPConfigTableHeader( u_int32_t pap ) >> printf( "MP Config Base Table Entries:\n\n" ); >> >> /* initialze tables */ >> - for ( x = 0; x < 16; ++x ) { >> + for ( x = 0; x < 256; ++x ) { > > `nitems(busses)` (requires sys/param.h)? Sure. Fixed in: http://svnweb.freebsd.org/base?view=revision&revision=244530 best Neel > >> busses[ x ] = apics[ x ] = 0xff; >> >> } > > Thanks, > -Garrett