From owner-svn-src-head@FreeBSD.ORG  Wed Feb 25 20:31:50 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C3E5110656DB;
	Wed, 25 Feb 2009 20:31:50 +0000 (UTC)
	(envelope-from rnoland@FreeBSD.org)
Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195])
	by mx1.freebsd.org (Postfix) with ESMTP id 6DFE58FC1A;
	Wed, 25 Feb 2009 20:31:50 +0000 (UTC)
	(envelope-from rnoland@FreeBSD.org)
Received: from [192.168.1.2] (adsl-156-5-199.bna.bellsouth.net [70.156.5.199])
	(authenticated bits=0)
	by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n1PKUBjI013447
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 25 Feb 2009 15:30:11 -0500 (EST)
	(envelope-from rnoland@FreeBSD.org)
From: Robert Noland <rnoland@FreeBSD.org>
To: Ed Schouten <ed@80386.nl>
In-Reply-To: <20090225194228.GS19161@hoeg.nl>
References: <200902251854.n1PIsZZP005285@svn.freebsd.org>
	<20090225194228.GS19161@hoeg.nl>
Content-Type: multipart/signed; micalg="pgp-sha1";
	protocol="application/pgp-signature";
	boundary="=-iMyVnHwWpDrn5pEhARqC"
Organization: FreeBSD
Date: Wed, 25 Feb 2009 14:31:25 -0600
Message-Id: <1235593885.1273.80.camel@widget.2hip.net>
Mime-Version: 1.0
X-Mailer: Evolution 2.24.4 FreeBSD GNOME Team Port 
X-Spam-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC
	autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r189052 - head/sys/dev/drm
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2009 20:31:51 -0000


--=-iMyVnHwWpDrn5pEhARqC
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 2009-02-25 at 20:42 +0100, Ed Schouten wrote:
> Hi Robert,
>=20
> * Robert Noland <rnoland@FreeBSD.org> wrote:
> > +static struct drm_msi_blacklist_entry drm_msi_blacklist[] =3D {
> > +	{0x8086, 0x2772}, /* Intel i945G	*/ \
> > +	{0x8086, 0x27A2}, /* Intel i945GM	*/ \
> > +	{0x8086, 0x27AE}, /* Intel i945GME	*/ \
> > +	{0, 0}
> > +};
>=20
> Wouldn't it be better to use PCI_VENDOR_INTEL/PCI_PRODUCT_INTEL_*
> definitions here?

Where are those located?  The rest of drm just uses the hex id's, if
there is a better way, I'm up for it.

robert.

--=20
Robert Noland <rnoland@FreeBSD.org>
FreeBSD

--=-iMyVnHwWpDrn5pEhARqC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (FreeBSD)

iEYEABECAAYFAkmlqp0ACgkQM4TrQ4qfROM5vgCfU2jw5FRWMHOeqPmzrwPu7HPS
V/EAn1jC7KGYGKbi6/4Yg/EDrRZw5J0h
=vjqq
-----END PGP SIGNATURE-----

--=-iMyVnHwWpDrn5pEhARqC--