From nobody Mon Sep 20 03:22:22 2021
X-Original-To: python@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2F037178C67E
	for <python@mlmmj.nyi.freebsd.org>; Mon, 20 Sep 2021 03:22:22 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4HCVH20dZBz53P7
	for <python@FreeBSD.org>; Mon, 20 Sep 2021 03:22:22 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EBD8A134E
	for <python@FreeBSD.org>; Mon, 20 Sep 2021 03:22:21 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org ([127.0.1.5])
	by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 18K3MLpu041116
	for <python@FreeBSD.org>; Mon, 20 Sep 2021 03:22:21 GMT
	(envelope-from bugzilla-noreply@freebsd.org)
Received: (from www@localhost)
	by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 18K3ML2n041114
	for python@FreeBSD.org; Mon, 20 Sep 2021 03:22:21 GMT
	(envelope-from bugzilla-noreply@freebsd.org)
X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f
From: bugzilla-noreply@freebsd.org
To: python@FreeBSD.org
Subject: [Bug 258593] [NEW] sysutils/py-puremagic: Pure python implementation
 of magic file detection
Date: Mon, 20 Sep 2021 03:22:22 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: feature, needs-patch, needs-qa
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: james@french.id.au
X-Bugzilla-Status: Open
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-258593-21822-NJ1tCiFF6W@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-258593-21822@https.bugs.freebsd.org/bugzilla/>
References: <bug-258593-21822@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-python
List-Help: <mailto:python+help@freebsd.org>
List-Post: <mailto:python@freebsd.org>
List-Subscribe: <mailto:python+subscribe@freebsd.org>
List-Unsubscribe: <mailto:python+unsubscribe@freebsd.org>
Sender: owner-freebsd-python@freebsd.org
X-BeenThere: freebsd-python@freebsd.org
MIME-Version: 1.0
X-Spam: Yes
X-ThisMailContainsUnwantedMimeParts: N

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258593

--- Comment #3 from James French <james@french.id.au> ---
Thanks for the review Kubilay, I'm working on an update that will address t=
hose
issues and should have it back later today.

Just on the test suite, the python code for the tests is distributed with t=
he
source but the data files they depend on is not (presumably because it's qu=
ite
a large set of data). The test suite will always fail from a PyPi tarball, =
even
if the code is fine.

I can cobble something together that sources those files from GitHub to make
the test suite work but it may overcomplicate the port. Not sure if this is
something we should do or not.

In either case, I will probably submit two patches one with and one without
fetching that data.

Cheers,
James

--=20
You are receiving this mail because:
You are on the CC list for the bug.=