From owner-freebsd-arm@FreeBSD.ORG Mon Jun 21 13:47:27 2010 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 392211065674; Mon, 21 Jun 2010 13:47:27 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109]) by mx1.freebsd.org (Postfix) with ESMTP id C68BA8FC1E; Mon, 21 Jun 2010 13:47:26 +0000 (UTC) Received: from localhost (unknown [213.17.239.109]) by smtp.semihalf.com (Postfix) with ESMTP id CFB70C42DA; Mon, 21 Jun 2010 15:52:55 +0200 (CEST) X-Virus-Scanned: by amavisd-new at semihalf.com Received: from smtp.semihalf.com ([213.17.239.109]) by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new, port 10024) with ESMTP id q-xL1bAvYjV0; Mon, 21 Jun 2010 15:52:55 +0200 (CEST) Received: from [10.0.0.79] (cardhu.semihalf.com [213.17.239.108]) by smtp.semihalf.com (Postfix) with ESMTPSA id 01EADC42D5; Mon, 21 Jun 2010 15:52:54 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii From: Rafal Jaworowski In-Reply-To: <20100621131830.GF31846@nereid> Date: Mon, 21 Jun 2010 15:47:24 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <4AD04D0B-C12C-4909-8BAB-533D7B60157A@semihalf.com> References: <20100620220302.8eb84547.nork@FreeBSD.org> <20100621123239.GD31846@nereid> <79FA8A01-E855-405B-B967-BF2BF972DD2D@semihalf.com> <20100621131830.GF31846@nereid> To: Kristof Provost X-Mailer: Apple Mail (2.1081) Cc: freebsd-arm@FreeBSD.org, Alexander Motin , Warner Losh , Norikatsu Shigemura Subject: Re: OpenRD-Client/Ultimate support X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2010 13:47:27 -0000 On 2010-06-21, at 15:18, Kristof Provost wrote: > On 2010-06-21 14:46:02 (+0200), Rafal Jaworowski = wrote: >>=20 >> On 2010-06-21, at 14:32, Kristof Provost wrote: >>=20 >>> On 2010-06-21 14:08:47 (+0200), Rafal Jaworowski = wrote: >>>>=20 >>>> On 2010-06-20, at 15:03, Norikatsu Shigemura wrote: >>>>> 2. Change how to set PHY numbers. >>>>> Suggested by: Kristof Provost >>>>=20 >>>> Please elaborate on what is being fixed with PHY numbering here. >>>>=20 >>> The driver simply didn't work if there were multiple ethernet ports. >>> It always programmed the address of the first available PHY for = both. >>=20 >> I thought we tested with two ports on MV-78100, but maybe something = didn't make it to the SVN tree or got mismerged. So what is the part of = the patch that fixes this problem, is it this hunk? >>=20 > Perhaps it did work on the MV-78100 because the bootloader initialised > the MGE_REG_PHYDEV. Before r201198 the driver simply didn't set that > register so the driver only worked if the bootloader did that for us. That's possible, yes. >> @@ -716,8 +718,7 @@ >> sc->mii =3D device_get_softc(sc->miibus); >>=20 >> /* Tell the MAC where to find the PHY so autoneg works */ >> - miisc =3D LIST_FIRST(&sc->mii->mii_phys); >> - MGE_WRITE(sc, MGE_REG_PHYDEV, miisc->mii_phy); >> + MGE_WRITE(sc, MGE_REG_PHYDEV, sc->phyaddr); >>=20 >> /* Attach interrupt handlers */ >> for (i =3D 0; i < 2; ++i) { >>=20 >=20 > That's the one. Ok, this looks ok to me. Rafal