From owner-cvs-src@FreeBSD.ORG Fri Feb 20 11:59:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B1CBF16A4CF; Fri, 20 Feb 2004 11:59:27 -0800 (PST) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8759A43D2F; Fri, 20 Feb 2004 11:59:27 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (localhost [127.0.0.1]) by ns1.xcllnt.net (8.12.10/8.12.10) with ESMTP id i1KJxROE021086; Fri, 20 Feb 2004 11:59:27 -0800 (PST) (envelope-from marcel@ns1.xcllnt.net) Received: (from marcel@localhost) by ns1.xcllnt.net (8.12.10/8.12.10/Submit) id i1KJxQLg021085; Fri, 20 Feb 2004 11:59:26 -0800 (PST) (envelope-from marcel) Date: Fri, 20 Feb 2004 11:59:26 -0800 From: Marcel Moolenaar To: Bruce Evans Message-ID: <20040220195926.GA20936@ns1.xcllnt.net> References: <200401192127.i0JLRBL3041817@repoman.freebsd.org> <200402180839.09285.jhb@FreeBSD.org> <20040218174059.GC7878@ns1.xcllnt.net> <200402181414.01381.jhb@FreeBSD.org> <20040220191831.B4626@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040220191831.B4626@gamplex.bde.org> User-Agent: Mutt/1.5.5.1i cc: src-committers@FreeBSD.org cc: John Baldwin cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Poul-Henning Kamp cc: Jun Kuriyama Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2004 19:59:27 -0000 On Fri, Feb 20, 2004 at 07:32:09PM +1100, Bruce Evans wrote: > On Wed, 18 Feb 2004, John Baldwin wrote: > > > On Wednesday 18 February 2004 12:40 pm, Marcel Moolenaar wrote: > > > I like the behaviour of MPASS(), just not its name and the fact it's > > > defined in lock.h. If we can call it ASSERT and move its definition > > > to systm.h, then I'm hooked. > > MPASS() has the same problems as line numbers in panic messages (except > for the implementation bugs (misformatting of the output etc.)): verbose > messages and breakage of simple regression tests. Note that however you look at it, failed assertions and panics are expected to not happen. I hope at least that we're not designing the kernel based on the frequent occurrence of these. In case they do happen, I expect that they help in identifying the root cause. If a failed assertion or a panic breaks a simple regression test, it means there's a bug and that it needs to be found and fixed. You're not supposed to complain that the message printed by the assert or panic logic messes up the testing. So, verbosity is of lesser concern than having concise, to the point and informative messages that stand out enough to be noticed and actually help developers to start triaging the problem and get to the bottom of it. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net