From owner-svn-src-head@freebsd.org Thu Feb 15 03:48:20 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25CB7F1BEB8 for ; Thu, 15 Feb 2018 03:48:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A8DE37FE0E for ; Thu, 15 Feb 2018 03:48:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x230.google.com with SMTP id o13so17750722ito.2 for ; Wed, 14 Feb 2018 19:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=rWMv9ny2NVak8POaHA41XoU/1yDC9h1dG2Ugiqacqgk=; b=HKziAGRn7yZBDDVhlE4DJp/JYXnT6Mrwag+255pkijmzUvVzHPi4OA51oP7IAuCbJ0 ypuBI56Vh4msj7IBVI3hCPSkXXcA3PBGuiXLv9FvCfMaGcXlkVTHscUocDtrSA8UShbc S6abrrqi61reyN+4gA9JxoG1WXsQ9856sJGmVkli/Yt8Hkfblj0yyhid9Vr84LM8GHep TMRfzPaB1QO2CnOWcFtCFzI1Je1JEVvROX4rZBHIIR9uxebKyvct5bqPNs6np6fAGSIU F6avhGiNc0Hkzkrj8iQlspCTw+finK6RyJ+lDxmHlw1dBhQzJI/v0F3XbfWiqV974ARU Z55w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=rWMv9ny2NVak8POaHA41XoU/1yDC9h1dG2Ugiqacqgk=; b=UjKF30c8qcsu+MCcMGGHxBdernni+uhmdH83sm2ch5xoWxqWBVLaujKJ7h69l+9WWC RmxtwOG7mjD8doOtNcUr7mSUGvqVKpUr0uBe3TapZzQl26fDl49Ks68q5/UVicx6L7FU 0AgC/gOXYYff8m0m4Jyen324Lujz7AW8/NNvGwiViZvLfvm6aUEe8WbDM+z3JBYDDzRZ 93ZhkWpD8X3IJM1jvoFS6d9q7+/qx09tu3BqtdQ5/ZK/bW5Nl+Q27IkP7YwDv/6G1mnN 7Jos7sWVOc7ogX8RP+GmMPk/QVA/XkPDqEyEjA8+TJJXNR8kyfhBOjoHZgDz+VVTTvX1 ymEg== X-Gm-Message-State: APf1xPARGt7//OL3ojrdW+phBxFrhn53wzUigJD3ROcTWILjYxO2yA28 VmHO/vOQHx5fRdWWOOTqJ7JRb7yl2tC15zeF4zpYFA== X-Google-Smtp-Source: AH8x225W+GX1H0vBstb9iVM+oY3UUkapty6qKsLNto6rY8viPZp1heh90dKT3Nb63EaWCn5W5nCxkM04u/nNYlSG1sk= X-Received: by 10.36.54.66 with SMTP id l63mr1712304itl.50.1518666498892; Wed, 14 Feb 2018 19:48:18 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Wed, 14 Feb 2018 19:48:17 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:18a2:a4f7:170:8dd9] In-Reply-To: References: <201802150322.w1F3Mrie018786@repo.freebsd.org> From: Warner Losh Date: Wed, 14 Feb 2018 20:48:17 -0700 X-Google-Sender-Auth: He8XBqbzz7KSorqQJpudx0r3r0s Message-ID: Subject: Re: svn commit: r329296 - head/sbin/devd To: Eitan Adler Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2018 03:48:20 -0000 On Wed, Feb 14, 2018 at 8:39 PM, Warner Losh wrote: > > > On Feb 14, 2018 8:23 PM, "Eitan Adler" wrote: > > Author: eadler > Date: Thu Feb 15 03:22:53 2018 > New Revision: 329296 > URL: https://svnweb.freebsd.org/changeset/base/329296 > > Log: > devd: don't pass &fds in useless parameters to select(2) > > select(2) should be declared as restrict. In addition the only fd in > the fdset is open O_RDONLY, and it's not a socket that can provide OOB > notifications, > > Reviewed by: ian, imp, vangyzen > > > Don't put my name on this. I specifically and clearly objected to the > change anf tld yoy not to do it. > Stupid phone... I specifically objected to this change. I said not to make it because it wasn't necessary. You did it any way. Don't put "reviewed by" for that. Put "objected to but I did it anyway by: imp" Warner > > Warner > > > Modified: > head/sbin/devd/devd.cc > > Modified: head/sbin/devd/devd.cc > ============================================================ > ================== > --- head/sbin/devd/devd.cc Thu Feb 15 03:22:04 2018 (r329295) > +++ head/sbin/devd/devd.cc Thu Feb 15 03:22:53 2018 (r329296) > @@ -1021,7 +1021,7 @@ event_loop(void) > tv.tv_usec = 0; > FD_ZERO(&fds); > FD_SET(fd, &fds); > - rv = select(fd + 1, &fds, &fds, &fds, &tv); > + rv = select(fd + 1, &fds, NULL, NULL, &tv); > // No events -> we've processed all pending events > if (rv == 0) { > devdlog(LOG_DEBUG, "Calling daemon\n"); > > >