From owner-cvs-all  Sun Feb 18 19:22:58 2001
Delivered-To: cvs-all@freebsd.org
Received: from lerami.lerctr.org (lerami.lerctr.org [207.158.72.11])
	by hub.freebsd.org (Postfix) with ESMTP
	id C760E37B401; Sun, 18 Feb 2001 19:22:48 -0800 (PST)
Received: (from ler@localhost)
	by lerami.lerctr.org (8.11.2/8.11.2/20010112/$Revision: 1.13 $) id f1J3Ml816379;
	Sun, 18 Feb 2001 21:22:47 -0600 (CST)
	(envelope-from ler)
Date: Sun, 18 Feb 2001 21:22:47 -0600
From: Larry Rosenman <ler@lerctr.org>
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet fil.c ip_auth.c ip_auth.h ip_compat.h ip_fil.c ip_fil.h ip_frag.c ip_frag.h ip_ftp_pxy.c ip_log.c ip_nat.c ip_nat.h ip_proxy.h ip_raudio_pxy.c ip_rcmd_pxy.c ip_state.c ip_state.h ipl.h mlfk_ipl.c
Message-ID: <20010218212247.A16370@lerami.lerctr.org>
References: <200102172042.f1HKg9A20215@freefall.freebsd.org> <200102190119.f1J1J8P32906@earth.backplane.com> <20010218191724.H6641@fw.wintelcom.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.15i
In-Reply-To: <20010218191724.H6641@fw.wintelcom.net>; from bright@wintelcom.net on Sun, Feb 18, 2001 at 07:17:24PM -0800
X-Mailer: Mutt http://www.mutt.org/
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

* Alfred Perlstein <bright@wintelcom.net> [010218 21:17]:
> > :darrenr     2001/02/17 12:42:09 PST
> > :
> > :  Modified files:        (Branch: RELENG_4)
> > :    sys/netinet          fil.c ip_auth.c ip_auth.h ip_compat.h 
> > :                         ip_fil.c ip_fil.h ip_frag.c ip_frag.h 
> > :                         ip_ftp_pxy.c ip_log.c ip_nat.c ip_nat.h 
> > :                         ip_proxy.h ip_raudio_pxy.c ip_rcmd_pxy.c 
> > :                         ip_state.c ip_state.h ipl.h mlfk_ipl.c 
> > :  Log:
> > :  merge changes from 3.4.8 to 3.4.16
> 
> * Matt Dillon <dillon@earth.backplane.com> [010218 17:19] wrote:
> >     What in god's name is this?  
> > 
> >     This one MFC appears to cover commits made to current going all the
> >     way back to October 2000, all in one go.  Darren, did you actually
> >     test this stuff in aggregate under -stable significantly before MFCing it?
> > 
> >     Also, these changes should be MFC'd piecemeal, not all at once, and
> >     the commit message is completely opaque.  There appear to be all sorts
> >     of things mixed in here... nat changes, ipv6 changes, base ip and tcp
> >     protocol changes, etc.  
> > 
> >     -stable is what people have in production.  I really, really, really do
> >     not think this sort of everything-under-the-sun commit is prudent.  I
> >     can see doing an aggregate commit for IPV6 conditionalized things, since
> >     it's still experimental in -stable, but not everything else.
> 
> This is contrib software, he's entitiled to the same sort of
> guidelines as sendmail, gcc, bind, etc.  He doesn't develop ipfilter
> _for_ FreeBSD, he mearly does the import management for his program
> as if he was the "ipfilter" guru (because he is).
> 
> If there's any sort of problem because of this it will look bad
> for ipfilter, not FreeBSD.  Also, if you don't like or trust his
> commit style, then there's always ipfw. :)
AND, he gets lots of us testing it BEFORE he integrates it. 

See the IPFilter mailing list.

It's nice that he FINALLY imported it into RELENG_4.

LER
-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message