From owner-cvs-all Wed Jan 24 16:46:36 2001 Delivered-To: cvs-all@freebsd.org Received: from harmony.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 22BE137B400; Wed, 24 Jan 2001 16:46:11 -0800 (PST) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f0P0k5963107; Wed, 24 Jan 2001 17:46:06 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200101250046.f0P0k5963107@harmony.village.org> To: mjacob@feral.com Subject: Re: cvs commit: src/sys/pci if_fxp.c if_fxpvar.h Cc: "Justin T. Gibbs" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Wed, 24 Jan 2001 15:59:36 PST." References: Date: Wed, 24 Jan 2001 17:46:05 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message Matthew Jacob writes: : Warner said somehing like making this part of hints, which I guess would use : this. I'll send some code... : Look- I just did it like I have done it in isp_pci. I'm sure there are a lot : better ways to do that and I welcome people to improve upon things. It's just : too damned bad that people can't document interfaces so we know that they're : their to be used. Point taken. I'll see about documenting resource_int_value and resource_query_string in section 9 of the man page. I've just looked at isahint.c each time that I need them, but maybe man pages would be better. If you wanted to use the device_get_flags() for this (which might also be a good way to go?), then you may need to fix the pci code to fetch this from the hints tables. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message