From owner-svn-src-all@freebsd.org Mon May 18 21:09:18 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 959C42DD77E for ; Mon, 18 May 2020 21:09:18 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from 44-233-67-66-mail.ore.mailhop.org (44-233-67-66-mail.ore.mailhop.org [44.233.67.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49Qs8G22sVz4NM8 for ; Mon, 18 May 2020 21:09:18 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1589836156; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=YfMhvxzSmLoaBBTG7lGKLC8auS36e7oZMavVtjGYz/KPzGorgEbQ1GCuzxUWTExUP72JPekSIsgUl kwj0rcW5R67HdJLn2hbcQh3gf9Asddo8pNyr859SlSMmXzpfvq9bFbkRirTdnupNn5fPkbS5q/sh5N eMWa+Byp5DxClvPv0Ig2lzOwOeguM7y8vM6WJ9HnYiF6RDr8jVaW/Zb4XP0tV+dTBkB3arbr2Iy7x2 karZu6RIHvK+H+lkWeRW/jlx1eKjLJDXQsDcTy5ESEz2rHfcKQu+x7XDZEIj3SM6McYEGzivbzErck s8q2ZSw9H4h7VwG203s7abXcVle4IjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=PNkeR7XS2C3IMBmZhFi0Uespe0wlYubfB/YpxfBNC34=; b=qCRkEtdi6xv6YUSBrug0QC4k99W4sUEWEL+ka0y9SuxB/+j9o4F7/VL8HfsOxKniJ3aGSfmMXmUQu kZNh6UgCqj+zNkP04+HpDsOcH6rBOjIwIf9Ce3BTxWtTOqGYn4yT5mLmFQMNiCZo8WVqih3WZzyi1Q RwVsrWtJgvM/f/xkHvfz5xCON5pTFzALmHNMCglyBaoDrX+QqfF1Jql1CF8wHOCRpdKHCYWjAjgDux T7Mq3CCpkIUJOym5sP3IgKfRzoFNmuUlHREoCXt6IgZk9MYFvX4Ky8AVfrIA88paqFgoAm/djPMZDh HBcA4shO8ua01xXxI0VSwnYN9BA93aQ== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=PNkeR7XS2C3IMBmZhFi0Uespe0wlYubfB/YpxfBNC34=; b=QSQYx7YPR9s/jD8x0lzwh/xmpwePwe64yjr8bngayPKLIIuho/VzJe2R/v4/YA+7+jHrtCg0ap/wx IdvR0G9Tk/VdxpWDu2Vrz2Hjzq1nbDU2H3VPh7pHchWBr5TvcoLMHjfh2q1thjqIs2+HY6qc5owoR9 jrcX19xr8aVydFNhfpLIBu/Vqr2A3WFXcEoPYQFe4XHUOECX5jL8H+TRbqQlvp1pMpLaHLgqlxqjM8 e8iPIeGYOuRBkBNhFu57r2s4vvd+zhEUMGGzLBXDVpo37DfU5QTirWlY2BH/O6gaVxmbX3GtU4r3oA kiBp2RTVh9BRCCsf37MicPt/fsFeu+Q== X-MHO-RoutePath: aGlwcGll X-MHO-User: d42aabc7-994b-11ea-b10c-b5956a7dd1a1 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id d42aabc7-994b-11ea-b10c-b5956a7dd1a1; Mon, 18 May 2020 21:09:15 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 04IL9EQH003283; Mon, 18 May 2020 15:09:14 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <90bc5fc67941a0b3ad8235351cfc303dc3a37c40.camel@freebsd.org> Subject: Re: svn commit: r361209 - head/sys/netinet From: Ian Lepore To: Michael Tuexen Cc: cem@freebsd.org, src-committers , svn-src-all , svn-src-head Date: Mon, 18 May 2020 15:09:14 -0600 In-Reply-To: <58B8E5E9-8DA1-4453-B1A3-A90D97D5FD43@freebsd.org> References: <202005181007.04IA713t089936@repo.freebsd.org> <064C2DCD-6279-4442-A900-0ECCD50CC4FA@freebsd.org> <124078163fc75e82a0acaff85f57859d012c6d98.camel@freebsd.org> <58B8E5E9-8DA1-4453-B1A3-A90D97D5FD43@freebsd.org> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49Qs8G22sVz4NM8 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:16509, ipnet:44.224.0.0/11, country:US]; local_wl_from(0.00)[freebsd.org] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2020 21:09:18 -0000 On Mon, 2020-05-18 at 23:01 +0200, Michael Tuexen wrote: > > On 18. May 2020, at 22:48, Ian Lepore wrote: > > > > On Mon, 2020-05-18 at 22:43 +0200, Michael Tuexen wrote: > > > > Sure. You can certainly ignore user reports corresponding to > > > > bogus > > > > flags, though, and encourage use of various flags. > > > > > > I could, but decided to improve the situation for some people, > > > but > > > wasn't realising that I made it worse for others. Sorry about > > > that. > > > > I'm trying to figure out why your original commit was a problem. I > > understand why it was questioned, but once the answer came out, > > it's > > clear that the code you originally committed does what it's > > supposed to > > without any harmful side effects. Sure, freebsd doesn't strictly > > need > > I guess the point Conrad is making, that on FreeBSD the check is not > needed, since the call can not fail. So the FreeBSD code base would > not > be consistent: within the SCTP related code the return code is > checked, > in the other code it is not. > > it, but the code is shared among projects, so what's the harm in > > the > > extra check that helps other projects sharing the code? It's > > certainly > > a lot less confusion and code clutter than any of the "remedies" > > that > > have been discussed. > > Yepp, sharing code between platforms makes things harder. Running the > same > code in kernel land and userland does not make it simpler. Different > groups > have different opinions/styles/... > > I'll revert the commit tomorrow and a variadic macros > SCTP_SNPRINTF(), which > will map on FreeBSD to snprintf() and on the other platforms will do > the check. > > If the build problem comes up on FreeBSD userland (and I have no idea > if that > is the case, since I don't know how Firefox / Chrome are build on > FreeBSD), > I leave it up to the port maintainer of the application to deal with > it. > > Best regards > Michael > > > > -- Ian > > > > Well it seems to me you're being asked to do a lot of extra work that has the final result of making the code LESS clear and MORE complex, because of one person's opinion. I'm actually a bit tempted to complain about the change, because to me it reduces rather than improves code quality. -- Ian