From owner-svn-src-head@FreeBSD.ORG Thu Mar 12 21:35:36 2015 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B7BA5453; Thu, 12 Mar 2015 21:35:36 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 276FCE4D; Thu, 12 Mar 2015 21:35:35 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t2CLZUF9008804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 12 Mar 2015 23:35:30 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t2CLZUF9008804 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t2CLZUfb008803; Thu, 12 Mar 2015 23:35:30 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 12 Mar 2015 23:35:30 +0200 From: Konstantin Belousov To: Nathan Whitehorn Subject: Re: svn commit: r279937 - in head/sys/powerpc: include powerpc Message-ID: <20150312213530.GT2379@kib.kiev.ua> References: <201503122115.t2CLFdmi026986@svn.freebsd.org> <20150312212234.GS2379@kib.kiev.ua> <55020547.7050102@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55020547.7050102@freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 21:35:36 -0000 On Thu, Mar 12, 2015 at 02:29:43PM -0700, Nathan Whitehorn wrote: > > On 03/12/15 14:22, Konstantin Belousov wrote: > > On Thu, Mar 12, 2015 at 09:15:39PM +0000, Nathan Whitehorn wrote: > >> Author: nwhitehorn > >> Date: Thu Mar 12 21:15:38 2015 > >> New Revision: 279937 > >> URL: https://svnweb.freebsd.org/changeset/base/279937 > >> > >> Log: > >> Provide VSX context in ucontext(3) API. > >> > >> Modified: > >> head/sys/powerpc/include/ucontext.h > >> head/sys/powerpc/powerpc/exec_machdep.c > >> > >> Modified: head/sys/powerpc/include/ucontext.h > >> ============================================================================== > >> --- head/sys/powerpc/include/ucontext.h Thu Mar 12 20:14:48 2015 (r279936) > >> +++ head/sys/powerpc/include/ucontext.h Thu Mar 12 21:15:38 2015 (r279937) > >> @@ -46,6 +46,7 @@ typedef struct __mcontext { > >> uint32_t mc_av[2]; > >> register_t mc_frame[42]; > >> uint64_t mc_fpreg[33]; > >> + uint64_t mc_vsxfpreg[32]; /* low-order half of VSR0-31 */ > >> } mcontext_t __aligned(16); > >> > >> #if defined(_KERNEL) && defined(__powerpc64__) > >> @@ -60,6 +61,7 @@ typedef struct __mcontext32 { > >> uint32_t mc_av[2]; > >> uint32_t mc_frame[42]; > >> uint64_t mc_fpreg[33]; > >> + uint64_t mc_vsxfpreg[32]; /* low-order half of VSR0-31 */ > >> } mcontext32_t __aligned(16); > >> #endif > > It looks as if you broken the ABI compatibility by the change. Am I wrong ? > > > > That is correct. It's a tier-2 platform and -CURRENT, so I'm not sure > it's worth the compatibility shims. I'm happy to add them if you think > otherwise. You are main maintainer of PowerPC port, IMO, so it is your decision. Note that 'this is current' argument is not applicable, since the change also breaks stable/* binaries. I do understand the argument of PowerPC being tier 2 architecture, but this makes me sad. Anyway, it is yours. For x86, I have to introduce getcontextx(3) mechanism.