From owner-svn-src-head@FreeBSD.ORG Wed Jan 7 01:07:43 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8D07B439; Wed, 7 Jan 2015 01:07:43 +0000 (UTC) Received: from mail-ig0-x22f.google.com (mail-ig0-x22f.google.com [IPv6:2607:f8b0:4001:c05::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E8441093; Wed, 7 Jan 2015 01:07:43 +0000 (UTC) Received: by mail-ig0-f175.google.com with SMTP id h15so5102488igd.2; Tue, 06 Jan 2015 17:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=KTyBqVA9eOiGBi+UscPBf4YkAce+qBmMjy91tY4Gy9c=; b=JEDKE1QM4pdkeTIl2Kys0ceOmptQUbTLqOgcCOJzRC0aXbGm9DEnAra4boQRWEBMCP lg7VOxoJCGshEQeK6PgsiAMjsYJoVzwFK4db+Ibc2SI+EIP0SMiQMEpd2Zpqu9pjsp14 3g3GOIniG8rpSIdHWE1CpbUavXrfeoeZkcS7XEobP5YDeV/iQt59WMEAzqx13bEfKJaP +CdiL/8+rCBp8ANOTTkjVzx9PmJmOdc0T44Q9mTqk89mUtixFq9BzSo3XvLEbctkrqKe n2nFF9AqGeUisLc0FlhAawmwnmpHK9mJiiCKurHCjqXyBaLJUYUoVP3S3Tgud/qEGtn6 RsBQ== X-Received: by 10.107.46.165 with SMTP id u37mr288117iou.80.1420592862638; Tue, 06 Jan 2015 17:07:42 -0800 (PST) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.0.171 with HTTP; Tue, 6 Jan 2015 17:07:11 -0800 (PST) In-Reply-To: <54AC6F4E.1000707@FreeBSD.org> References: <201410100609.s9A690NU067686@svn.freebsd.org> <54AC6F4E.1000707@FreeBSD.org> From: Bryan Venteicher Date: Tue, 6 Jan 2015 19:07:11 -0600 X-Google-Sender-Auth: j9m4FZ27coo4ONI8wt3Pve6V5KY Message-ID: Subject: Re: svn commit: r272886 - in head/sys: netinet netinet6 To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , Bryan Venteicher , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , John Nielsen X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jan 2015 01:07:43 -0000 On Tue, Jan 6, 2015 at 5:27 PM, Bryan Drewery wrote: > On 1/6/2015 4:00 PM, Bryan Venteicher wrote: > > > > > > On Tue, Jan 6, 2015 at 2:52 PM, John Nielsen > > wrote: > > > > Bryan- > > > > On Oct 10, 2014, at 12:09 AM, Bryan Venteicher > > wrote: > > > > > Author: bryanv > > > Date: Fri Oct 10 06:08:59 2014 > > > New Revision: 272886 > > > URL: https://svnweb.freebsd.org/changeset/base/272886 > > > > > > Log: > > > Add context pointer and source address to the UDP tunnel callback > > > > > > These are needed for the forthcoming vxlan implementation. The > context > > > pointer means we do not have to use a spare pointer field in the > inpcb, > > > and the source address is required to populate vxlan's forwarding > table. > > > > > > While I highly doubt there is an out of tree consumer of the UDP > > > tunneling callback, this change may be a difficult to eventually > MFC. > > > > I noticed this comment while doing an MFC of vxlan to my local tree. > > Do you think an MFC to 10-STABLE of this change (and vxlan > > generally) will be feasible? Is there precedent for ABI changes like > > this being sanctioned? Could symbol versioning help? > > > > > > > > I'd like to get some consensus on whether this commit is OK to MFC. With > > this commit, vxlan should be an easy to MFC. > > Breaking ABI will potentially hurt packages. FreeBSD builds packages for > the oldest supported release on a branch. If you break ABI in 10.2 while > we are building packages for 10.1 then any packages using these > interfaces may not work right or result in panics packages with kmods. > Please consider that. > > The only user visible change of this commit would be the addition of a field at the end of 'struct udpcb'. I don't think that is a problem, at least a similar change didn't prevent the MFC of UDP Lite. The kernel part of this changes the UDP tunneling functions which I guess there could be a 3rd party module out there, but I very highly doubt that, based on how un-useful the previous interface was. > > > > > > > > Phabricator: https://reviews.freebsd.org/D383 > > > Reviewed by: gnn > > > > > > Modified: > > > head/sys/netinet/sctputil.c > > > head/sys/netinet/udp_usrreq.c > > > head/sys/netinet/udp_var.h > > > head/sys/netinet6/udp6_usrreq.c > > > > Thanks, > > > > JN > > > > > > > -- > Regards, > Bryan Drewery >