From owner-svn-src-all@freebsd.org Tue Dec 17 17:17:25 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C7E2A1ED120; Tue, 17 Dec 2019 17:17:25 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward102j.mail.yandex.net (forward102j.mail.yandex.net [5.45.198.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47clFJ18jWz4Ydw; Tue, 17 Dec 2019 17:17:23 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward100q.mail.yandex.net (forward100q.mail.yandex.net [IPv6:2a02:6b8:c0e:4b:0:640:4012:bb97]) by forward102j.mail.yandex.net (Yandex) with ESMTP id 22F97F200BA; Tue, 17 Dec 2019 20:17:20 +0300 (MSK) Received: from mxback2q.mail.yandex.net (mxback2q.mail.yandex.net [IPv6:2a02:6b8:c0e:40:0:640:9c8c:4946]) by forward100q.mail.yandex.net (Yandex) with ESMTP id 1CCA87080004; Tue, 17 Dec 2019 20:17:20 +0300 (MSK) Received: from vla4-a16f3368381d.qloud-c.yandex.net (vla4-a16f3368381d.qloud-c.yandex.net [2a02:6b8:c17:d85:0:640:a16f:3368]) by mxback2q.mail.yandex.net (mxback/Yandex) with ESMTP id AIAWy8FpPE-HJd4HkJK; Tue, 17 Dec 2019 20:17:20 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1576603040; bh=DEjhmYtBNrU7L4R8gbxb4b0vYu/BmpMgpPzwqUQE1LA=; h=In-Reply-To:From:Date:References:To:Subject:Message-ID; b=TLr/aEfVACksWVcHCAB4Itz/YMSHbztXjfaD+w72gDq1fQKonGq1kfqx9+UAeW4fl xT0F/2y3y6VK7xw2G58f7/EgzfsUkxqxw1yEm88i5eAmNBFMmogvCP7Ns0hYM1rtpA vH6jzQxph7mlCOltTPFt2f8JfTJtJDsGAcaOq95w= Received: by vla4-a16f3368381d.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id 5wY9MyfDJt-HJVKtfXw; Tue, 17 Dec 2019 20:17:19 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Subject: Re: svn commit: r341578 - head/sys/dev/mlx5/mlx5_en To: Hans Petter Selasky , Slava Shwartsman , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201812051420.wB5EKwxr099242@repo.freebsd.org> <8715aa7b-ceea-7cfd-1980-a260c98070d5@yandex.ru> <6151923d-05bb-b945-359e-d632708ba021@selasky.org> From: "Andrey V. Elsukov" Openpgp: id=E6591E1B41DA1516F0C9BC0001C5EA0410C8A17A Autocrypt: addr=bu7cher@yandex.ru; prefer-encrypt=mutual; keydata= mQENBEwBF1kBCADB9sXFhBEUy8qQ4X63Y8eBatYMHGEFWN9ypS5lI3RE6qQW2EYbxNk7qUC5 21YIIS1mMFVBEfvR7J9uc7yaYgFCEb6Sce1RSO4ULN2mRKGHP3/Sl0ijZEjWHV91hY1YTHEF ZW/0GYinDf56sYpDDehaBF5wkWIo1+QK5nmj3vl0DIDCMNd7QEiWpyLVwECgLX2eOAXByT8B bCqVhJGcG6iFP7/B9Ll6uX5gb8thM9LM+ibwErDBVDGiOgvfxqidab7fdkh893IBCXa82H9N CNwnEtcgzh+BSKK5BgvPohFMgRwjti37TSxwLu63QejRGbZWSz3OK3jMOoF63tCgn7FvABEB AAG0JUFuZHJleSBWLiBFbHN1a292IDxidTdjaGVyQHlhbmRleC5ydT6JATgEEwECACIFAkwB F1kCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEAHF6gQQyKF6qmYIAI6ekfm1VA4T vqankI1ISE6ku4jV7UlpIQlEbE7/8n3Zd6teJ+pGOQhN5qk8QE7utdPdbktAzi+x7LIJVzUw 4TywZLXGrkP7VKYkfg6oyCGyzITghefQeJtr2TN4hYCkzPWpylkue8MtmqfZv/6royqwTbN+ +E09FQNvTgRUYJYTeQ1qOsxNRycwvw3dr2rOfuxShbzaHBB1pBIjGrMg8fC5pd65ACH5zuFV A0CoTNGMDrEZSfBkTW604UUHFFXeCoC3dwDZRKOWJ3GmMXns65Ai5YkA63BSHEE1Qle3VBhd cG1w0CB5FBV3pB27UVnf0jEbysrDqW4qN7XMRFSWNAy5AQ0ETAEXWQEIAJ2p6l9LBoqdH/0J PEFDY2t2gTvAuzz+8zs3R03dFuHcNbOwjvWCG0aOmVpAzkRa8egn5JB4sZaFUtKPYJEQ1Iu+ LUBwgvtXf4vWpzC67zs2dDuiW4LamH5p6xkTD61aHR7mCB3bg2TUjrDWn2Jt44cvoYxj3dz4 S49U1rc9ZPgD5axCNv45j72tggWlZvpefThP7xT1OlNTUqye2gAwQravXpZkl5JG4eOqJVIU X316iE3qso0iXRUtO7OseBf0PiVmk+wCahdreHOeOxK5jMhYkPKVn7z1sZiB7W2H2TojbmcK HZC22sz7Z/H36Lhg1+/RCnGzdEcjGc8oFHXHCxUAEQEAAYkBHwQYAQIACQUCTAEXWQIbDAAK CRABxeoEEMihegkYCAC3ivGYNe2taNm/4Nx5GPdzuaAJGKWksV+w9mo7dQvU+NmI2az5w8vw 98OmX7G0OV9snxMW+6cyNqBrVFTu33VVNzz9pnqNCHxGvj5dL5ltP160JV2zw2bUwJBYsgYQ WfyJJIM7l3gv5ZS3DGqaGIm9gOK1ANxfrR5PgPzvI9VxDhlr2juEVMZYAqPLEJe+SSxbwLoz BcFCNdDAyXcaAzXsx/E02YWm1hIWNRxanAe7Vlg7OL+gvLpdtrYCMg28PNqKNyrQ87LQ49O9 50IIZDOtNFeR0FGucjcLPdS9PiEqCoH7/waJxWp6ydJ+g4OYRBYNM0EmMgy1N85JJrV1mi5i Message-ID: <60698d75-ca26-da71-682c-ec7d24f0eab6@yandex.ru> Date: Tue, 17 Dec 2019 20:14:35 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <6151923d-05bb-b945-359e-d632708ba021@selasky.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C3uohgIZIngDLk3qugCqJrUeptLYnHMh7" X-Rspamd-Queue-Id: 47clFJ18jWz4Ydw X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yandex.ru header.s=mail header.b=TLr/aEfV; dmarc=pass (policy=none) header.from=yandex.ru; spf=pass (mx1.freebsd.org: domain of bu7cher@yandex.ru designates 5.45.198.243 as permitted sender) smtp.mailfrom=bu7cher@yandex.ru X-Spamd-Result: default: False [-6.20 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:5.45.192.0/19]; FREEMAIL_FROM(0.00)[yandex.ru]; HAS_ATTACHMENT(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[yandex.ru:+]; DMARC_POLICY_ALLOW(-0.50)[yandex.ru,none]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[243.198.45.5.list.dnswl.org : 127.0.5.1]; ASN(0.00)[asn:13238, ipnet:5.45.192.0/18, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[yandex.ru:s=mail]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVFROM(0.00)[yandex.ru]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; IP_SCORE(0.00)[ipnet: 5.45.192.0/18(-4.82), asn: 13238(-3.78), country: RU(0.01)]; IP_SCORE_FREEMAIL(0.00)[]; DWL_DNSWL_LOW(-1.00)[yandex.ru.dwl.dnswl.org : 127.0.5.1]; TO_MATCH_ENVRCPT_SOME(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Dec 2019 17:17:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C3uohgIZIngDLk3qugCqJrUeptLYnHMh7 Content-Type: multipart/mixed; boundary="YAMnh3pzM1iWcSxXeJlDRplnwIdZABgpc"; protected-headers="v1" From: "Andrey V. Elsukov" To: Hans Petter Selasky , Slava Shwartsman , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <60698d75-ca26-da71-682c-ec7d24f0eab6@yandex.ru> Subject: Re: svn commit: r341578 - head/sys/dev/mlx5/mlx5_en References: <201812051420.wB5EKwxr099242@repo.freebsd.org> <8715aa7b-ceea-7cfd-1980-a260c98070d5@yandex.ru> <6151923d-05bb-b945-359e-d632708ba021@selasky.org> In-Reply-To: <6151923d-05bb-b945-359e-d632708ba021@selasky.org> --YAMnh3pzM1iWcSxXeJlDRplnwIdZABgpc Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 13.12.2019 17:27, Hans Petter Selasky wrote: > On 2019-12-13 14:40, Andrey V. Elsukov wrote: >> On 05.12.2018 17:20, Slava Shwartsman wrote: >>> Author: slavash >>> Date: Wed Dec=C2=A0 5 14:20:57 2018 >>> New Revision: 341578 >>> URL: https://svnweb.freebsd.org/changeset/base/341578 >>> >>> Log: >>> =C2=A0=C2=A0 mlx5en: Remove the DRBR and associated logic in the tran= smit path. >>> =C2=A0=C2=A0 =C2=A0=C2=A0 The hardware queues are deep enough current= ly and using the >>> DRBR and associated >>> =C2=A0=C2=A0 callbacks only leads to more task switching in the TX pa= th. The is >>> also a race >>> =C2=A0=C2=A0 setting the queue_state which can lead to hung TX rings.= >> >> JFYI. We have compared the same router+firewall workloads on the host >> with this change and before, and I can say, that without DRBR on TX no= w >> we constantly have several percents of packets drops due to ENOBUFS >> error from mlx5e_xmit(). >> >=20 > Have you tried to tune the TX/RX parameters? >=20 > Especially the tx_queue_size . We use the following settings: % sysctl dev.mce.4.conf. | grep que dev.mce.4.conf.rx_queue_size: 16384 dev.mce.4.conf.tx_queue_size: 16384 dev.mce.4.conf.rx_queue_size_max: 16384 dev.mce.4.conf.tx_queue_size_max: 16384 Also, previously I have patched MLX5E_SQ_TX_QUEUE_SIZE value up to 16384.= --=20 WBR, Andrey V. Elsukov --YAMnh3pzM1iWcSxXeJlDRplnwIdZABgpc-- --C3uohgIZIngDLk3qugCqJrUeptLYnHMh7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAl35DPsACgkQAcXqBBDI oXpjAAgAjWJhnrYCqMijx0rsjTxwwVfVGImL4JpYARwEJ8TKNk/5tYyH8WNb9LrS GQoE0dSoalxgSc5m7hV/LlX1qi188h2j3+FljiekU0It8RiIWAzvIMp9xpFwDpi4 nZ5O9ppAJ+O3XFOV9K4P3R/5l4mPy9AVAmYDnk9qMKGfk7L/Pej8fFq/h0s3Vo9o Zq67OGTRkfqRQLUiMRfrIo+mM46NWAW6Z/8Wo1Gu23mkOif4DIUP0HeJLyU+/nl/ 1WtD3NGprsN1IXqF7D32L7HAeTfvF8GF9TOTNm3QIi+vhZQtwL0grG+cxjcVHIU3 arCa/iuWJkbZJcPucTv+yczzQDXsGg== =DBXn -----END PGP SIGNATURE----- --C3uohgIZIngDLk3qugCqJrUeptLYnHMh7--