From owner-cvs-src@FreeBSD.ORG  Mon Sep 26 11:31:32 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DD42916A41F;
	Mon, 26 Sep 2005 11:31:32 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 778D343D49;
	Mon, 26 Sep 2005 11:31:32 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by cyrus.watson.org (Postfix) with ESMTP id 5CAD146B1C;
	Mon, 26 Sep 2005 07:31:29 -0400 (EDT)
Date: Mon, 26 Sep 2005 12:31:29 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Bruce Evans <bde@zeta.org.au>
In-Reply-To: <20050926212051.J21547@delplex.bde.org>
Message-ID: <20050926123058.X11229@fledge.watson.org>
References: <200509260802.j8Q82PFW064658@repoman.freebsd.org>
	<20050926212051.J21547@delplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/kern subr_prf.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Sep 2005 11:31:33 -0000


On Mon, 26 Sep 2005, Bruce Evans wrote:

>>  Acquire Giant in uprintf() and tprintf() rather than asserting it.  In
>>  the vast majority of cases, these functions are called without mutexes
>>  held, meaning that in all but two cases, there will be no ordering
>>  issues with doing this, and it will eliminate the need for changes in
>>  the caller.  In two cases, mutexes are held, so Giant must be acquired
>>  before those mutexes such that uprintf() and tprintf() recurse Giant
>>  rather than generating a lock order reversal.
>
> Thansks.

I'll take a jaunt through the rest of the tree removing the Giant 
acquisitions (in most cases) later this afternoon (local time)

Robert N M Watson