Date: Wed, 19 Jul 95 14:13:28 MDT From: terry@cs.weber.edu (Terry Lambert) To: dillon@blob.best.net (Matt Dillon) Cc: mckusick@McKusick.COM, davidg@root.com, bugs@freebsd.org Subject: Re: possible ffs_vget() race condition Message-ID: <9507192013.AA28881@cs.weber.edu> In-Reply-To: <199507191809.LAA07002@blob.best.net> from "Matt Dillon" at Jul 19, 95 11:09:16 am
next in thread | previous in thread | raw e-mail | index | archive | help
> Oh, there are also some pretty serious problems with the sysctl() > stuff... mainly with all the list traversals the sysctl()'s do > without locking and the copyout's inside the loops (which can > block, causing the list being traverse and most specifically the > 'current' item to be ripped out from under sysctl())... I had > to stop using pstat -T because of the problem (it would crash > the machine every couple of hours). A lot of the system configuration stuff is bogus/unportable/both. The use of manifest constants to do the descriptor structs in sysctl.h is patently bogus. The CTLTYPE_QUAD definition and the size variant CTLTYPE_INT are both rather annoying; these should be sized values, and QUAD should probably not be allowed at all, since 64 bit values are (as yet) intolerably unportable. Not to mention the use of a shift of an embeded constant '63' and a -1 to get the RLIM_INFINITY value in resource.h. Instead of (~(u_quad_t)0). Anything touching on quad code is pretty much half baked. Terry Lambert terry@cs.weber.edu --- Any opinions in this posting are my own and not those of my present or previous employers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9507192013.AA28881>