From nobody Thu Apr 16 15:56:49 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fxN1G0llZz6ZtCV for ; Thu, 16 Apr 2026 15:56:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fxN1F67fzz3NY4 for ; Thu, 16 Apr 2026 15:56:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776355009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VTitpA+xJioxWYX7JNKN91nhvYg6b5J3eaZPZkTpKQw=; b=hkhLvDuzZWr8dbaXr0Jzlc06oocTPzS9UyoJOfa+1mQhmoh72XrE1WtTPYVSXek5ovR5Z4 xK2QBw4fA7GXTP8oVWlg/zANcXl92xo1pK7Obuvn15AKLVgyC+4pS0s1w2ZxibuAp8wrh8 TxRvSXc24A5rb+83hxqAS2UeqnNgScO2DdoZ9o8JzEMC/zb1dyLaa+g0fa0TgNed7FO2Z9 mQoBypzx+aQiF+Dgmojr6uMwtqfdoEgMHSwnGNAdxJ1X1lRaGBBFthU8tyFwyf8K0fisHJ Ww0T8CHnvj68vbzRwk38EC88G9qSddhdlWuL91jCqu1Dc30xekDbEQwoNOpIzw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776355009; a=rsa-sha256; cv=none; b=JpopKrnMUtoM75BR/PJpW+Ii8wDsk74XJanxsm9bg09HCmjxXGvB5VY738uydHhrRVD/Z1 R2aYeMLlxmvUdgnXzsqlboKAB1TT3BAtNRlMsGgryai20EAknAfjexI6mHLeatl8yGgRQe 9p9X75okAwIx3jBVqPxc3P+oNVFwQ1GNl5q39rvWnTorP/IWqS33j9gnQbin79Kac9Vn5E dxpXCGK0jHbuhZ6jf0VZ05tb4C45Ln0nU2mnF0MJeGLd3p2dNKCZRdthMORQbCyEFlpR21 4F5nVOfBsQgj5Z0k9i0m1d8nhofb5Sw2eWGbb/3hBti4nVAfK3Mare/G11hwpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776355009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VTitpA+xJioxWYX7JNKN91nhvYg6b5J3eaZPZkTpKQw=; b=NtoCLUzF1tp3qdh+0Bwxv8ap3k90RQWWia97BGLwU7zAmhWObyHyBIw4GMptgRB9dzUB4/ O004pXRMMl2uQtikYXgXyPNpNfJ5h3Oi6Q1wcvzY2fTqjk+A6AMxG80CqX5u3qH8ZDI4fo zmTvYHSgd6da71Y7gLQ1N6dUlXFTpsTwAW2d+40lz+zrv3abfKZapp1l2M3ogJrkavNgFe nOy4a7Q3xM5+4futmtrvWt1fWg7/iA0SVRbxpkGLbQHd3sylw0k/2Us6iSz58S03m1DKBe HMfcCjZEmGwWktmMdPd4w0IxWdbMRZnZIAjcSD2bBIUhn9/hcK3BpqoI/C6xZw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fxN1F1btgz98 for ; Thu, 16 Apr 2026 15:56:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2227b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 16 Apr 2026 15:56:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 1379cde85f61 - stable/15 - imgact_elf: Unconditionally initialize a variable in a note handler List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 1379cde85f6177fa457aec9bd7a100424a990a60 Auto-Submitted: auto-generated Date: Thu, 16 Apr 2026 15:56:49 +0000 Message-Id: <69e106c1.2227b.27d49071@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=1379cde85f6177fa457aec9bd7a100424a990a60 commit 1379cde85f6177fa457aec9bd7a100424a990a60 Author: Mark Johnston AuthorDate: 2026-04-08 04:19:56 +0000 Commit: Mark Johnston CommitDate: 2026-04-16 15:56:26 +0000 imgact_elf: Unconditionally initialize a variable in a note handler In the sb == NULL case, we are computing the size of the note using a dummy sbuf drain handler which counts bytes and discards the contents of the buffer, so the fact that "structsize" is uninitialized doesn't matter. But, the compiler may complain about this, so we might as well just initialize it unconditionally to silence the warning, as other handlers already do. PR: 292811 MFC after: 1 week (cherry picked from commit 8a68c2509c00ae0dbeab64064bb600cfac787a73) --- sys/kern/imgact_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/imgact_elf.c b/sys/kern/imgact_elf.c index 7410efca4807..c91fd8089487 100644 --- a/sys/kern/imgact_elf.c +++ b/sys/kern/imgact_elf.c @@ -2714,6 +2714,7 @@ __elfN(note_procstat_auxv)(void *arg, struct sbuf *sb, size_t *sizep) int structsize; p = arg; + structsize = sizeof(Elf_Auxinfo); if (sb == NULL) { size = 0; sb = sbuf_new(NULL, NULL, AT_COUNT * sizeof(Elf_Auxinfo), @@ -2727,7 +2728,6 @@ __elfN(note_procstat_auxv)(void *arg, struct sbuf *sb, size_t *sizep) sbuf_delete(sb); *sizep = size; } else { - structsize = sizeof(Elf_Auxinfo); sbuf_bcat(sb, &structsize, sizeof(structsize)); PHOLD(p); proc_getauxv(curthread, p, sb);