From owner-cvs-src@FreeBSD.ORG Sat Apr 9 13:37:01 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AEF1216A4CE; Sat, 9 Apr 2005 13:37:01 +0000 (GMT) Received: from acampi.inet.it (acampi.inet.it [213.92.1.165]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17A7B43D4C; Sat, 9 Apr 2005 13:37:01 +0000 (GMT) (envelope-from andrea@acampi.inet.it) Received: by acampi.inet.it (Postfix, from userid 1000) id 7975120; Sat, 9 Apr 2005 15:36:59 +0200 (CEST) Date: Sat, 9 Apr 2005 15:36:59 +0200 From: Andrea Campi To: Hajimu UMEMOTO Message-ID: <20050409133658.GA34278@webcom.it> References: <200504061536.j36FaY00056103@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504061536.j36FaY00056103@repoman.freebsd.org> User-Agent: Mutt/1.5.9i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/net getaddrinfo.c name6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Apr 2005 13:37:01 -0000 On Wed, Apr 06, 2005 at 03:36:34PM +0000, Hajimu UMEMOTO wrote: > ume 2005-04-06 15:36:34 UTC > > FreeBSD src repository > > Modified files: > lib/libc/net getaddrinfo.c name6.c > Log: > - we are no longer shareing any resources to be locked between > getaddrinfo(3) and getipnodeby*(3). > - use definitions in reentrant.h. > - remove obsolete comment. This commit breaks a NO_NIS buildworld in name6.c, as gcc warns about static _getipnodeby_thread_lock being unused, and we are compiling at a high enough warning level for this to be fatal. The macros are only used in the YP and ICMPNL cases, so you could fix this by wrapping the macro definition: #if defined(YP) || defined(ICMPNL) static mutex_t _getipnodeby_thread_lock = MUTEX_INITIALIZER; #define THREAD_LOCK() mutex_lock(&_getipnodeby_thread_lock); #define THREAD_UNLOCK() mutex_unlock(&_getipnodeby_thread_lock); #endif Bye, Andrea -- The best things in life are free, but the expensive ones are still worth a look.