From owner-svn-src-all@freebsd.org Wed Jan 15 20:33:08 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F4F71FC8D6 for ; Wed, 15 Jan 2020 20:33:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47yfCl3Xkbz3yGC for ; Wed, 15 Jan 2020 20:33:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82b.google.com with SMTP id v25so16970487qto.7 for ; Wed, 15 Jan 2020 12:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7NYfMJQLJJP2T8coI6qnZF+A6MsOpYIL2oZta7tnAH8=; b=mw/7B9foZTp31scgl7RmYSLxBsIyJnCm55YdiicouL9zCHhNNXmg+EsZPM8VjMKXLn jwYS9Lgz+ux2n1M5J/K6X8FbBH8bmX72Z1Gi6VKXavRHKRDvJAs29NLKPKGpzrnO3xk1 jrQzZP/5cSyHHwTHsm8HUdmskPsmwrr+my/StltupeseLCZ42wvYUVR6By23o1aO3s3z goJtrMFKcxwuJzzhB9YNPJ488P5r/iP+9mj4vMao2EI8Qed5aMNCtGXrT+nCFwdkW+O2 U18AgRCpQSfyfArAM187FJ5Sag5owXw0L+aTuYn5zIjJy3AT5BQIDdBHeT8Ij2R+AYLy 2Wzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7NYfMJQLJJP2T8coI6qnZF+A6MsOpYIL2oZta7tnAH8=; b=K7nqfqOu8Evo6417TSAdMHpsBopWNDkF6czhx0QQQ6+RUWpRjrcU5v4jQqJ2xUJNlV AOepMckT9kfNrTTSWEYyRYrl9p6Z05r+ViFRl08cNDbpeBObyj0UJozDiHc5VvIUmWly QgZy3SGXX6XGWillpW0j92ghmFTSuDvlcuYG1osgWfKXOhzbeujtTKSAZmEdeh9Ulde9 gAChBESP8sVerpPeYZDOnNBC8+EYJ06qq9/gcnemV1+phItF6OeL3jPQnrKrhQFYwLXs WQHxru3x1HCO3Xp9m1/bI8tu6TaPfs5R5Y4BFKBAW+X1yFlMzRL7S9mRoummbpc3tpIS c/GA== X-Gm-Message-State: APjAAAVxUBP9Onl97b0H6SqVl0HEph19R4aOagi8j0bjZwHrZTrD6uwR mWdsPKGpLcXkZEVixonRx6GU8Ub5KgSdYnYcPbspwg== X-Google-Smtp-Source: APXvYqwc1a0szg5KGvOklnhG7OPKPl2Wuoy+oitFLB1sByNlZb4C54GrwF3TuXam/3zEjPAzQ4N3snzllr+j9qc6P0s= X-Received: by 2002:ac8:3198:: with SMTP id h24mr410648qte.291.1579120386106; Wed, 15 Jan 2020 12:33:06 -0800 (PST) MIME-Version: 1.0 References: <202001150747.00F7lqiG071097@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 15 Jan 2020 13:32:55 -0700 Message-ID: Subject: Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts To: Nathan Whitehorn Cc: Oliver Pinter , Ben Woods , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Ed Maste X-Rspamd-Queue-Id: 47yfCl3Xkbz3yGC X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=mw/7B9fo; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::82b) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.16 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[b.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.66)[ip: (-9.33), ipnet: 2607:f8b0::/32(-2.09), asn: 15169(-1.83), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; SUSPICIOUS_RECIPS(1.50)[]; FREEMAIL_CC(0.00)[gmail.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2020 20:33:08 -0000 On Wed, Jan 15, 2020 at 12:10 PM Nathan Whitehorn wrote: > I agree -- this seems like a really big change, especially with no > discussion. > I agree this is the right thing to do. ZFS is the best fit for most people (there are exceptions, and they can install UFS and if ZFS isn't right for you, you're likely well aware of it[*]). ZFS is a huge asset to FreeBSD, and we should lead with strength. And the UFS option is there for people that don't want ZFS. Nothing changes there... In an ideal world, it likely should have been socialized first on arch@ (it's likely still good to chat about it there). It would likely be good to kick off a discussion there, but honestly, this should be a fairly boring, bland change for most people in our core, target market. There's little compelling reason to not use ZFS, unless your work load hits the fairly narrow range where ZFS isn't so good. Warner [*] Netflix uses UFS because of sendfile efficiencies, but we don't use the installer to install our systems: we have our own custom one our system integrators use since it has a lot of extra specific checks we need, but that aren't relevant to others. And my personal systems are almost all ZFS (the ones that aren't date from a time that ZFS wasn't in the system, or too new for me to trust it). > -Nathan > > On 2020-01-15 10:57, Oliver Pinter wrote: > > > > > > On Wednesday, January 15, 2020, Ben Woods > > wrote: > > > > Author: woodsb02 (ports committer) > > Date: Wed Jan 15 07:47:52 2020 > > New Revision: 356758 > > URL: https://svnweb.freebsd.org/changeset/base/356758 > > > > > > Log: > > bsdinstall: Change "default" (first) Partitioning method to ZFS > > > > Reported by: Ruben Schade (during his talk at linux.conf.au > > ) > > Approved by: philip > > Differential Revision: https://reviews.freebsd.org/D23173 > > > > > > > > What's the justification behind this change? > > Plus I miss from here the relontes tag. > > > > > > > > > > Modified: > > head/usr.sbin/bsdinstall/bsdinstall.8 > > head/usr.sbin/bsdinstall/scripts/auto > > > > Modified: head/usr.sbin/bsdinstall/bsdinstall.8 > > > ============================================================================== > > --- head/usr.sbin/bsdinstall/bsdinstall.8 Wed Jan 15 > > 06:18:32 2020 (r356757) > > +++ head/usr.sbin/bsdinstall/bsdinstall.8 Wed Jan 15 > > 07:47:52 2020 (r356758) > > @@ -119,7 +119,7 @@ Provides the installer's interactive guided > > disk parti > > installations. > > Defaults to UFS. > > .It Cm zfsboot > > -Provides an alternative ZFS-only automatic interactive disk > > partitioner. > > +Provides a ZFS-only automatic interactive disk partitioner. > > Creates a single > > .Ic zpool > > with separate datasets for > > > > Modified: head/usr.sbin/bsdinstall/scripts/auto > > > ============================================================================== > > --- head/usr.sbin/bsdinstall/scripts/auto Wed Jan 15 > > 06:18:32 2020 (r356757) > > +++ head/usr.sbin/bsdinstall/scripts/auto Wed Jan 15 > > 07:47:52 2020 (r356758) > > @@ -289,7 +289,7 @@ Shell \"Open a shell and partition by hand\"" > > CURARCH=$( uname -m ) > > case $CURARCH in > > amd64|arm64|i386) # Booting ZFS Supported > > - PMODES="$PMODES \"Auto (ZFS)\" \"Guided > Root-on-ZFS\"" > > + PMODES="\"Auto (ZFS)\" \"Guided Root-on-ZFS\" > $PMODES" > > ;; > > *) # Booting ZFS Unspported > > ;; > > @@ -303,6 +303,10 @@ PARTMODE=`echo $PMODES | xargs dialog > > --backtitle "Fre > > exec 3>&- > > > > case "$PARTMODE" in > > +"Auto (ZFS)") # ZFS > > + bsdinstall zfsboot || error "ZFS setup failed" > > + bsdinstall mount || error "Failed to mount filesystem" > > + ;; > > "Auto (UFS)") # Guided > > bsdinstall autopart || error "Partitioning error" > > bsdinstall mount || error "Failed to mount filesystem" > > @@ -319,10 +323,6 @@ case "$PARTMODE" in > > else > > bsdinstall partedit || error "Partitioning error" > > fi > > - bsdinstall mount || error "Failed to mount filesystem" > > - ;; > > -"Auto (ZFS)") # ZFS > > - bsdinstall zfsboot || error "ZFS setup failed" > > bsdinstall mount || error "Failed to mount filesystem" > > ;; > > *) > > _______________________________________________ > > svn-src-head@freebsd.org mailing > > list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > > > To unsubscribe, send any mail to > > "svn-src-head-unsubscribe@freebsd.org > > " > > > >