From nobody Sat Jul 15 03:59:18 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R2vjg4zsHz4mfn1; Sat, 15 Jul 2023 03:59:19 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R2vjg4Z5lz45Yd; Sat, 15 Jul 2023 03:59:19 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689393559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3IkuSoOwGWk/Q48s4yLLmCfpqphPpP0XMVtZB1E1TUY=; b=YtZfK9QkxUlNLvHfzN99q8XLkvE7k+nUKHElytUzNIfxSci7Vs/XGy5HZj/UCBDt0K+eaj CrUqI5z/zpnHr2HM4i+QA0//SeEvcmDv+SsGmX6fjCJd9Xg2RirqHebGyomJjJ2ZEfVPhv uYFJ2Bby8HwBpFiTnHLUzoHadJzSE1TaYNb9Q16nsmiiWY4Yl/AP+BXAhC9J3EG9PlV1PI JV8D53LjNS7f3jic19ZleYTodfojuhEnqxfTmMBHlY0Zyxjq+YthRSmWcH1tWzvpPaUom9 eH8WJ/2dB2x6EwtH3xYFJMF4HJ27jOOGiavClgFG/KobMxVsdaM/FvXMXNmE0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689393559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3IkuSoOwGWk/Q48s4yLLmCfpqphPpP0XMVtZB1E1TUY=; b=Vety6em6Hoh7qDIC7elmbJwXIO8A2nAPwuRkZ1pH7dQm8InFQZt7ojhhm2kjhvR6tqRLro kytPt+/24VmPjbXPwrRs7cGhqkjK6GPclTdGihWRM2r/ljHo2BI6mf7LJQ1sddTkd/A7u6 aERRz/An/ngMgPx2jwgbc4JHH2RjqvX8HL5Faa9XmmpaIgZQKyMjxPPkvQil3HmcMYN5ur LlbSBAdjwPpzKEFkplPiPyYoxE8n1Bpl0Zk7jESkCa7xo8mENIpBiAcSoY3bsrxjQi4WKR YRIYADhYWtyM3iRNubbyaIKWB5U+rJs4EvB+fRm7lB14H5tJ+K2psslbtkI+3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689393559; a=rsa-sha256; cv=none; b=KQaISn7mZ3yw2367D3BfivVwT2I/CmxgYPXZcEZmvUWWFW/RRjRQdBzQy3PorBBAP9IXSc ogAQI4jTPd1nvjkkudcrP1NsWkgTMGkg02wEolpwoWPyF07NnDfXAhW8GqlVG2JLQQOBvL zpfGgkzafI8IVpByGCLjFoimC1iyQ2KTu7U8Vra/GSgzFBoQxbrre6IMicwrHy3HJp7Ppv UmfvwwXDEtXJXRb+wRFp4f7Az2+TysUtg4eVhS7MZWhdDyWhBbKdZV8q3C38BGyiNjs8tF sce6k3jad7+qEAiGxEs+BM2Jvb/lElyLfm2KtRk8c3EqSCb2lo9AUDtgrF3Erg== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4R2vjg1shqz180h; Sat, 15 Jul 2023 03:59:19 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <54f0a239-ebc3-9496-f1b2-ea8eb15f80ba@FreeBSD.org> Date: Fri, 14 Jul 2023 22:59:18 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: git: 09267cc15284 - main - /etc/rc.subr: add support for kld sysctl variables Content-Language: en-US To: Doug Rabson , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202307140957.36E9vXtE047194@gitrepo.freebsd.org> From: Kyle Evans In-Reply-To: <202307140957.36E9vXtE047194@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 7/14/23 04:57, Doug Rabson wrote: > The branch main has been updated by dfr: > > URL: https://cgit.FreeBSD.org/src/commit/?id=09267cc15284795fef958fb9ed786bb2382d6763 > > commit 09267cc15284795fef958fb9ed786bb2382d6763 > Author: Doug Rabson > AuthorDate: 2023-06-21 12:26:17 +0000 > Commit: Doug Rabson > CommitDate: 2023-07-14 09:49:47 +0000 > > /etc/rc.subr: add support for kld sysctl variables > > For kernel modules loaded by scripts in /etc/rc.d and > /usr/local/etc/rc.d, if there is a file in /etc/sysctl.conf.d named name>.conf, then this will be loaded using the sysctl(8) utility. For > instance, sysctl variable changes for the pf kernel module would be > placed in the file /etc/sysctl.conf.d/pf.conf. > > PR: 272129 > Reviewed by: imp freebsd_igalic.co > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D40886 Hello! We discussed this out-of-band a little bit, but to circle back to the list: I'd like to propose changing the name of this directory before we cement it into a release; we've seen some non-zero amount of confusion with rc.conf.d (at least on IRC) because files within are actually conditionally sourced based on daemons being loaded. Many folks are conditioned to seeing $file.d as "just a way to split up $file," and when the contents are conditionally loaded it's not necessarily intuitive. We could document the behavior in hier(7) in additional to sysctl.conf(5), but IMO it'd be really nice for conditionally-sourced directories to be a little more descriptively named so that one could make an educated guess as to when the contents are used. For this one, perhaps "sysctl.kld.d"? I don't really know what to propose for rc.conf.d, perhaps rc.svcconf.d, but we'd need to actually implement rc.conf.d as you might guess it's implemented if we change it since it's seen a number of releases. Thanks, Kyle Evans