From nobody Fri Apr 29 15:55:52 2022 X-Original-To: freebsd-infiniband@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D549E199CDD6 for ; Fri, 29 Apr 2022 15:56:04 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KqcXg6Pqvz4Tt7 for ; Fri, 29 Apr 2022 15:56:03 +0000 (UTC) (envelope-from hps@selasky.org) Received: from [10.36.2.165] (unknown [176.74.213.87]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 0D7AD260510; Fri, 29 Apr 2022 17:55:53 +0200 (CEST) Message-ID: Date: Fri, 29 Apr 2022 17:55:52 +0200 List-Id: Infiniband on FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-infiniband List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-infiniband@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] ibcore: allow passing NULL-pointers to ib_umem_release() Content-Language: en-US To: dandan@lysator.liu.se, freebsd-infiniband@freebsd.org Cc: kempe@lysator.liu.se References: <20220429153345.Horde.6oVap54ZXOmz41donxfLJJ5@webmail.lysator.liu.se> From: Hans Petter Selasky In-Reply-To: <20220429153345.Horde.6oVap54ZXOmz41donxfLJJ5@webmail.lysator.liu.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4KqcXg6Pqvz4Tt7 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-1.31 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; NEURAL_HAM_LONG(-0.03)[-0.027]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[selasky.org]; NEURAL_SPAM_MEDIUM(0.01)[0.007]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.986]; MLMMJ_DEST(0.00)[freebsd-infiniband]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 4/29/22 17:33, dandan@lysator.liu.se wrote: > Hi! > > The attached patch fixes the following kernel panic in ibcore when > unloading the mlx4ib kernel module: > Hi! I've queued the patch internally at Mellanox/Nvidia for review. Will submit it on Monday most likely. Thank you! --HPS Slightly update commit message: > ibcore: Allow passing NULL-pointers to ib_umem_release() > > FreeBSD commit b633e08c705fe43180567eae26923d6f6f98c8d9 removed the > NULL-checks from the mlx4ib-driver. > > This fixes the following NULL-pointer panic when unloading mlx4ib: > ib_umem_release() > mlx4_ib_destroy_qp() > ib_destroy_qp_user() > ipoib_transport_dev_cleanup() > ipoib_dev_cleanup() > ipoib_remove_one() > ib_unregister_client() > ipoib_cleanup_module() > linker_file_sysuninit() > linker_file_unload() > kern_kldunload() > amd64_syscall() > > Linux commit: > 836a0fbb3e76f704ad65ddfb57f00725245e509b > > Submitted by: dandan@lysator.liu.se > Sponsored by: Lysator ACS