From owner-svn-src-all@freebsd.org Tue Mar 15 21:09:38 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C2A5AD0798; Tue, 15 Mar 2016 21:09:38 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-yw0-f180.google.com (mail-yw0-f180.google.com [209.85.161.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA95728CE; Tue, 15 Mar 2016 21:09:37 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-yw0-f180.google.com with SMTP id g127so37668678ywf.2; Tue, 15 Mar 2016 14:09:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=kIPMM13AJOAtZxkRxdrE4zH+Jeps0vgyVzCE6QmF0VA=; b=ma6JrinvlkyBe5fnMHp5z1xYYNK26xwSfhnkW7mrgbxz89JlujBGl5w3yMFUS4lRwG a9S+y3pAxJyk+ukgO3825W0ZAlYhW/+XvF80x0RWvndgKyioNWyw8UCj29PUy8bNrp1l Ws5hawlT1/j/duL52gusN5RkZJ0ZJy0/b6COJ3xLCiq2EG6IG2eF2VFmILhjvqzmqsW2 uy0ZDGzDe535pn1Irw4YbTddQxygKhOXPI4FYxyqfVW274z78nYav8V2/C+VsGczK9Gs Bnal16Xgz6NOb9WUJI4ulB/l4E+8vkURzihp3TLDY7mSOaxLiEWlLvFHvtJ8CqMVk0Ml UIdA== X-Gm-Message-State: AD7BkJIvJ9QNGMOPNbwO4A7SPkuikxex0U0Yec/dKw1j9Uf9vFVsVOYM/eu/91oGriwm1w== X-Received: by 10.129.97.7 with SMTP id v7mr9304ywb.237.1458074772347; Tue, 15 Mar 2016 13:46:12 -0700 (PDT) Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com. [209.85.161.171]) by smtp.gmail.com with ESMTPSA id f126sm18291581ywc.22.2016.03.15.13.46.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Mar 2016 13:46:12 -0700 (PDT) Received: by mail-yw0-f171.google.com with SMTP id m126so12948786ywd.0; Tue, 15 Mar 2016 13:46:11 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.13.217.77 with SMTP id b74mr23963ywe.73.1458074771769; Tue, 15 Mar 2016 13:46:11 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.37.115.134 with HTTP; Tue, 15 Mar 2016 13:46:11 -0700 (PDT) In-Reply-To: <201603152042.u2FKgafc073412@repo.freebsd.org> References: <201603152042.u2FKgafc073412@repo.freebsd.org> Date: Tue, 15 Mar 2016 13:46:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r296918 - head/sys/fs/autofs From: Conrad Meyer To: Edward Tomasz Napierala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2016 21:09:38 -0000 Instead you will get, "warning: unused but set variable 'error'" on -NODEBUG builds. Maybe add: (void)error; Best, Conrad On Tue, Mar 15, 2016 at 1:42 PM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Tue Mar 15 20:42:36 2016 > New Revision: 296918 > URL: https://svnweb.freebsd.org/changeset/base/296918 > > Log: > Pacify Coverity. > > MFC after: 1 month > Sponsored by: The FreeBSD Foundation > > Modified: > head/sys/fs/autofs/autofs_vnops.c > > Modified: head/sys/fs/autofs/autofs_vnops.c > ============================================================================== > --- head/sys/fs/autofs/autofs_vnops.c Tue Mar 15 19:45:24 2016 (r296917) > +++ head/sys/fs/autofs/autofs_vnops.c Tue Mar 15 20:42:36 2016 (r296918) > @@ -370,8 +370,10 @@ static size_t > autofs_dirent_reclen(const char *name) > { > size_t reclen; > + int error; > > - autofs_readdir_one(NULL, name, -1, &reclen); > + error = autofs_readdir_one(NULL, name, -1, &reclen); > + KASSERT(error == 0, ("autofs_readdir_one() failed")); > > return (reclen); > } >