From owner-cvs-all@FreeBSD.ORG Tue Jun 12 11:17:27 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E376A16A468 for ; Tue, 12 Jun 2007 11:17:27 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179]) by mx1.freebsd.org (Postfix) with ESMTP id B1F0F13C46C for ; Tue, 12 Jun 2007 11:17:27 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wa-out-1112.google.com with SMTP id j37so2713674waf for ; Tue, 12 Jun 2007 04:17:27 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=MGAoI8jaAoyQbQS1sVp0kh1AQ4hvKBE2YlbhrL1oQOtFYRKgCP8DbzNt1UluSKLk/TU9lhwYCGTjb5W0UVHygKiq2n9tLY875JnnHw5AhLiMrB//YlRQR+JLyDbQ+wu4woHNp1uRATyH7T7Os4W0hK4HdO0C459iUVcZhFgH7Vc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=iaeg3DOVIvLy1/GTRBDqE3sIlPv/TD6IhRmiYshg9aKTPy7+34d32z1G/xDxrErh+yLrup5GaGmUkhVMPRksXQrEqavzeSeCL9sJsc8RKjvwFZsInG6j1GuBYN7miCR5dK7MHPFDwNCRm+fIKKh6SHlW2fjReTnXMoiUPM8cqo0= Received: by 10.115.33.1 with SMTP id l1mr6576797waj.1181647047237; Tue, 12 Jun 2007 04:17:27 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTP id m40sm10471955waf.2007.06.12.04.17.24 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 12 Jun 2007 04:17:26 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l5CB0q0K047665 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 12 Jun 2007 20:00:52 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l5CB0qFx047664; Tue, 12 Jun 2007 20:00:52 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 12 Jun 2007 20:00:52 +0900 From: Pyun YongHyeon To: Andrew Gallatin Message-ID: <20070612110052.GH44998@cdnetworks.co.kr> References: <200706120235.l5C2Z1iJ022543@repoman.freebsd.org> <20070612060521.D84335@grasshopper.cs.duke.edu> <20070612103820.GG44998@cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070612103820.GG44998@cdnetworks.co.kr> User-Agent: Mutt/1.4.2.1i Cc: src-committers@FreeBSD.org, kmacy@FreeBSD.org, cvs-src@FreeBSD.org, davidch@FreeBSD.org, cvs-all@FreeBSD.org, jfv@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/nfe if_nfe.c if_nfereg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2007 11:17:28 -0000 On Tue, Jun 12, 2007 at 07:38:20PM +0900, To Andrew Gallatin wrote: > On Tue, Jun 12, 2007 at 06:05:21AM -0400, Andrew Gallatin wrote: > > Pyun YongHyeon [yongari@FreeBSD.org] wrote: > > > yongari 2007-06-12 02:35:01 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/nfe if_nfe.c if_nfereg.h > > > Log: > > > Increase a maximum segment size of DMA to 4096. Previously it used > > > MCLBYTES for the segment size but it used too many Tx descriptors in > > > TSO case. > > > While I'm here adjust maximum size of the sum of all segment lengths > > > in a given DMA mapping to 65535, the maximum size, in bytes, of a IP > > > > Can't it actually be 65535 + link layer headers? Eg, up to > > 65535 + 14 or 65535 + 18? > > > > Oops, you're right. It should be 65535 + sizeof(struct ether_vlan_header). > Thanks for pointing out! :) > I've checked TSO enabled drivers in tree. It seems that the following drivers also have the same bug. CCed to maintainers. bce(4), cxgb(4) and em(4). -- Regards, Pyun YongHyeon