From owner-cvs-all Tue Jul 9 10:33:31 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7194837B400; Tue, 9 Jul 2002 10:33:24 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0092543E42; Tue, 9 Jul 2002 10:33:24 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.5/8.12.2) with ESMTP id g69HXNoi026694; Tue, 9 Jul 2002 10:33:23 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.5/8.12.5/Submit) id g69HXN0Q026693; Tue, 9 Jul 2002 10:33:23 -0700 (PDT) Date: Tue, 9 Jul 2002 10:33:23 -0700 From: "David O'Brien" To: Robert Drehmel Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/svr4 svr4_sysvec.c Message-ID: <20020709173323.GA24994@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org Mail-Followup-To: David O'Brien , Robert Drehmel , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200207091459.g69ExRxg017714@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200207091459.g69ExRxg017714@freefall.freebsd.org> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Jul 09, 2002 at 07:59:27AM -0700, Robert Drehmel wrote: > robert 2002/07/09 07:59:27 PDT > > Modified files: > sys/compat/svr4 svr4_sysvec.c > Log: > The comment marked with XXX was right: emulate SVR4 for > ELF binaries branded with ELFOSABI_SYSV, this is reported > to work and brandelf(1) puts this type into files if "SVR4" > was specified. What was the report? Our SVR4 emulation was written around Solaris-x86. So using the Solaris branding is probably more proper. Note that ELFOSABI_SYSV is the same value as UN-branded. This has implications I'm not sure you thought about. Considering I'm the one that added the XXX comment: 1.11 (obrien 18-Apr-00): ELFOSABI_SOLARIS, /* XXX Or should we You might have wanted me to review this change. Also the SVR4 compat code will be used much more by our sparc64 platform than i386 one -- and there it will be used exclusively for Solaris binaries. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message