From owner-freebsd-current@freebsd.org Thu Jul 7 14:56:39 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF49EB82747 for ; Thu, 7 Jul 2016 14:56:39 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 75A9716EF for ; Thu, 7 Jul 2016 14:56:39 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-io0-x232.google.com with SMTP id f30so24168982ioj.2 for ; Thu, 07 Jul 2016 07:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sippysoft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3Z9WePur/z7UKJtXIPbjCfTAKWLduxXKC0V3YlMDneM=; b=ejCmA+ssow7vDvMtKHzDbfxotBARuiTx83QcRz2ryYOujppLi+h7i1ued5Ab1RTUkg uDqu659JB/SZO7L7n5tFAiBJzMr6HaFr5tdirPfiRbGBPHi/Da8gSK16XxL94fkgOtZE L1l0juXsWkg0/+9DKmUTzvDcu0xbhWKPgERfTIpGbs366nytYHJe1PhxmCo1FQsDnUfk tF6UL0ix0RwGfeRd65MhS7uZ0d1eFXBQM3aP/znwUWBJGujmCu3b2ADV8p+LIxlIjvTG WB9lQVfwcI3bO5pG4UdF+8UL3ePttJ7n9tOqA9rFL8AvS5oa4+uPq/6PWYrm4esvj5qo XkjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3Z9WePur/z7UKJtXIPbjCfTAKWLduxXKC0V3YlMDneM=; b=dgzbEnQ9I8KrixcIq/6j794TWVjMW0p//5XAWF/yQ+7ozgoW6QKJbB2VF+7StNDO5M 8Js4v+YNVTVY59z+FagUZaL1viceL1ls0GDCQPE4CNAWxMmSiRDmUjEHs52UnFdwFMXp 9Ze8oD8QnR4wi8C6GoxkfSip0X9afSx2SjRYujQdZxZhXASm5PBV6m9uKiKDZkHf4x1K 7UdtZS2Rzgs819WIN2e19y2bDwN0nA96EUR83j7Eulwmc243Z1U0yTd+tZ4GP4zCAImK vvPZfAX6SCeZ60NR0weuhEBt2tCWeduWtRQrQV7ECO8zMzLFvV5Lc8DuZ7ppNN4fxW5Q evnA== X-Gm-Message-State: ALyK8tKkgLCIc/WTjUnjT7JSztdQcQ5/n1lCD0ePq7KdWp+R7VpuqSB/1zJye30Y2gaZOSc8ETgaHPn2IXSZomMD X-Received: by 10.107.143.131 with SMTP id r125mr3325641iod.54.1467903398903; Thu, 07 Jul 2016 07:56:38 -0700 (PDT) MIME-Version: 1.0 Sender: sobomax@sippysoft.com Received: by 10.36.59.193 with HTTP; Thu, 7 Jul 2016 07:56:38 -0700 (PDT) In-Reply-To: References: <83A18C0E-FA89-4009-A8D5-3185FB27A688@netgate.com> From: Maxim Sobolev Date: Thu, 7 Jul 2016 07:56:38 -0700 X-Google-Sender-Auth: XVQ-OOIW09PcNjV1xkcpoXE-okw Message-ID: Subject: Re: BBB (cpsw(4)) seems to be broken in the latest 11-current To: Paul Mather , Luiz Otavio O Souza Cc: Keith White , "freebsd-arm@freebsd.org" , FreeBSD Current Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2016 14:56:39 -0000 Luiz, the patch works for me beautifully. Has not been able to reproduce the issue since applying it. Can you please merge it before 11.0 gets branched? Thanks! -Max On Tue, Jun 21, 2016 at 10:33 AM, Paul Mather wrote: > On Jun 20, 2016, at 6:33 PM, Keith White wrote: > > > On Mon, 20 Jun 2016, Luiz Otavio O Souza wrote: > > > >> On Sun, Jun 19, 2016 at 1:11 AM, Maxim Sobolev wrote: > >>> Jim, some update from here. Running r283287 of the driver, I still see > the > >>> same "watchdog timeout" messages, but they do not lead to the interface > >>> lockout. The traffic resumes momentarily. Which is probably why I > never paid > >>> much attention to those warnings before. Therefore, I suspect that the > new > >>> MAC code does not deal with watchdog-triggered interface reset as good > as > >>> the old code. Does it give you any ideas about what could be wrong > there by > >>> any chance? > >> > >> > >> Hi Maxim, > >> > >> My recent changes contributed somehow to expose the bug more frequently. > >> > >> There was a condition in tx packet reclamation where we aren't > >> restarting the tx queue in one of the possible stall conditions. > >> > >> Please try the attached patch and let me know if it works for you. > >> > >> Luiz > > > > Your patch fixes the problem for me. Thanks! > > > > FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #0 r302028M: Mon Jun > 20 18:19:55 EDT 2016 kwhite@freebsd11:/usr/obj/arm.armv6/usr/src/sys/BEAGLEBONE-LOCAL > arm armv6 > > > > ...keith > > > The patch also fixes the problem for me. > > FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #2 r302030M: Tue Jun 21 > 10:20:59 EDT 2016 pmather@beaglebone:/usr/obj/usr/src/sys/BEAGLEBONE-NO_WITNESS > arm > > > Cheers, > > Paul. > >