From owner-svn-ports-all@FreeBSD.ORG Mon Jun 3 20:01:26 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D067CA4E; Mon, 3 Jun 2013 20:01:26 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from homiemail-a67.g.dreamhost.com (mailbigip.dreamhost.com [208.97.132.5]) by mx1.freebsd.org (Postfix) with ESMTP id B35CA12D1; Mon, 3 Jun 2013 20:01:25 +0000 (UTC) Received: from homiemail-a67.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a67.g.dreamhost.com (Postfix) with ESMTP id D345D27BC06F; Mon, 3 Jun 2013 12:56:34 -0700 (PDT) Received: from lab (ip72-219-240-45.dc.dc.cox.net [72.219.240.45]) (Authenticated sender: trhodes@fbsdsecure.org) by homiemail-a67.g.dreamhost.com (Postfix) with ESMTPA id 3125427BC078; Mon, 3 Jun 2013 12:51:10 -0700 (PDT) Date: Mon, 3 Jun 2013 15:51:06 -0400 From: Tom Rhodes To: Bryan Drewery Subject: Re: svn commit: r319792 - head/sysutils/fsc Message-Id: <20130603155106.7f3e5826.trhodes@FreeBSD.org> In-Reply-To: <51ACDC95.4060600@FreeBSD.org> References: <201306031632.r53GWPdP069628@svn.freebsd.org> <51ACC994.4060608@FreeBSD.org> <20130603133012.114c2ae7.trhodes@FreeBSD.org> <51ACDC95.4060600@FreeBSD.org> X-Mailer: Sylpheed version 1.0.6 (GTK+ 1.2.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2013 20:01:27 -0000 On Mon, 03 Jun 2013 13:12:37 -0500 Bryan Drewery wrote: > On 6/3/2013 12:30 PM, Tom Rhodes wrote: > > On Mon, 03 Jun 2013 11:51:32 -0500 > > Bryan Drewery wrote: > > > >> This is bad form. If you are changing upstream code it should be a new > >> release version, not a reroll. We frequently have problems with other > >> upstreams doing this and should follow our own guidelines. > > > > I'm not bumping the version used for a simple gcc->clang warning > > fix. That's why I just bumped PORTVERSION. If we want to do a > > new version, I'll get ahold of the NetBSD people, who also work > > with keeping a port, and discuss doing that. In this case, it > > was a simple fix rather than adding a 2 line patch to a files/ > > directory. > > > > The proper way to do is this a new release, or a patch in files with a > PORTREVISION, or a sed in post-patch. This is the convention. Rerolling > upstream is a big no no. Rerolling is obscure and very frowned upon. > This also impacts NetBSD if they are tracking checksums, and any other > projects depending on the checksum of the upstream tarball. I'll look at bumping the release version - there are some other changes that need made anyway, I just wanted to fix the build so users could build it again. > > If you had a ports committer approve/review this change, which you > should have and should do in the future, this would have been avoided. I am a ports committer, sorry I forgot about this - considering I commit to this area rarely. So you can remind me about the rule, link to relevant documention, and I will remember for the future or "fix" the issue. No attitude needed. > > > > >> > >> On 6/3/2013 11:32 AM, Tom Rhodes wrote: > >>> Author: trhodes (src,doc committer) > >>> Date: Mon Jun 3 16:32:24 2013 > >>> New Revision: 319792 > >>> URL: http://svnweb.freebsd.org/changeset/ports/319792 > >>> > >>> Log: > >>> Update to fix breakage with clang. > >>> > >>> PR: 179050 > >>> Requested by: many > >>> > >>> Modified: > >>> head/sysutils/fsc/Makefile > >>> head/sysutils/fsc/distinfo > >>> > >>> Modified: head/sysutils/fsc/Makefile > >>> ============================================================================== > >>> --- head/sysutils/fsc/Makefile Mon Jun 3 16:02:16 2013 (r319791) > >>> +++ head/sysutils/fsc/Makefile Mon Jun 3 16:32:24 2013 (r319792) > >>> @@ -8,7 +8,7 @@ > >>> > >>> PORTNAME= fsc > >>> PORTVERSION= 1.0.1 > >>> -PORTREVISION= 1 > >>> +PORTREVISION= 2 > >>> CATEGORIES= sysutils > >>> MASTER_SITES= LOCAL > >>> MASTER_SITE_SUBDIR= trhodes > >>> > >>> Modified: head/sysutils/fsc/distinfo > >>> ============================================================================== > >>> --- head/sysutils/fsc/distinfo Mon Jun 3 16:02:16 2013 (r319791) > >>> +++ head/sysutils/fsc/distinfo Mon Jun 3 16:32:24 2013 (r319792) > >>> @@ -1,2 +1,2 @@ > >>> -SHA256 (fsc-1.0.1.tar.gz) = 3cae8021534dfc7074173ceca0ffd1483c2f58badb28663d6a99bcbf754e1f0a > >>> -SIZE (fsc-1.0.1.tar.gz) = 11708 > >>> +SHA256 (fsc-1.0.1.tar.gz) = 41979af3f5ed2fd37e30839cacc22408ac65f2fd20df30de1e5114bc0d2e733b > >>> +SIZE (fsc-1.0.1.tar.gz) = 12435 > >>> > >> > >> > >> -- > >> Regards, > >> Bryan Drewery > >> > >> > > > -- > Regards, > Bryan Drewery > >