From owner-svn-src-all@freebsd.org  Wed Nov 30 20:41:01 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33636C5E866
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Wed, 30 Nov 2016 20:41:01 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from pmta2.delivery6.ore.mailhop.org
 (pmta2.delivery6.ore.mailhop.org [54.200.129.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 177D01964
 for <svn-src-all@freebsd.org>; Wed, 30 Nov 2016 20:41:00 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 4a9ac7e5-b73d-11e6-9ec7-5d8fa496b077
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.78.92.27
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.78.92.27])
 by outbound2.ore.mailhop.org (Halon) with ESMTPSA
 id 4a9ac7e5-b73d-11e6-9ec7-5d8fa496b077;
 Wed, 30 Nov 2016 20:40:55 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id uAUKepYb001753;
 Wed, 30 Nov 2016 13:40:51 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1480538451.1889.187.camel@freebsd.org>
Subject: Re: svn commit: r309121 - head/usr.sbin/bhyve
From: Ian Lepore <ian@freebsd.org>
To: Jakub Klama <jakub@ixsystems.com>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Wed, 30 Nov 2016 13:40:51 -0700
In-Reply-To: <7F692FF4-4F36-4ED8-AF26-4684D41CB3AE@ixsystems.com>
References: <201611242216.uAOMGIi0065703@repo.freebsd.org>
 <1480026232.1889.63.camel@freebsd.org>
 <7F692FF4-4F36-4ED8-AF26-4684D41CB3AE@ixsystems.com>
Content-Type: text/plain; charset="iso-8859-2"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Nov 2016 20:41:01 -0000

On Thu, 2016-11-24 at 23:27 +0100, Jakub Klama wrote:
> > 
> > Wiadomość napisana przez Ian Lepore <ian@FreeBSD.org> w dniu
> > 24.11.2016, o godz. 23:23:
> > 
> > On Thu, 2016-11-24 at 22:16 +0000, Jakub Wojciech Klama wrote:
> > > 
> > > Author: jceel
> > > Date: Thu Nov 24 22:16:18 2016
> > > New Revision: 309121
> > > URL: https://svnweb.freebsd.org/changeset/base/309121
> > > 
> > > Log:
> > >  virtio_console: handle short writes to an Unix domain socket
> > > gracefully.
> > > 
> > >  writev() can do a short write.  Retrying it results in a very
> > > convoluted
> > >  and complex code, so we iterate over iovec and do regular
> > > stream_write()
> > >  instead.
> > > 
> > Doesn't pwritev(2) simplify iterating to handle short writes?
> > 
> Correct me if I'm wrong, but pwritev(2) is a writev(2) with offset.
> We're writing to an Unix domain socket here, which is not seekable.
> 
> Thanks,
> Jakub
> 
> 

My bad, I was under the impression the offset was an offset into the
iovec, not into the file.  So, ummm... nevermind. :)

-- Ian