Date: Tue, 15 Apr 2008 13:56:15 +0200 From: Daniel Roethlisberger <daniel@roe.ch> To: FreeBSD-gnats-submit@FreeBSD.org Cc: daniel@roe.ch Subject: ports/122791: [patch] net-mgmt/collectd - fix WITH_APACHE dependency and plist Message-ID: <E1Jljln-000OzP-MQ@calvin.roe.ch> Resent-Message-ID: <200804151200.m3FC09hx029213@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 122791
>Category: ports
>Synopsis: [patch] net-mgmt/collectd - fix WITH_APACHE dependency and plist
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Apr 15 12:00:09 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Daniel Roethlisberger
>Release: FreeBSD 6.3-RELEASE-p1 i386
>Organization:
>Environment:
System: FreeBSD calvin.roe.ch 6.3-RELEASE-p1 FreeBSD 6.3-RELEASE-p1 #0: Wed Feb 13 02:56:56 UTC 2008 root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/SMP i386
>Description:
If WITH_APACHE is used, collectd fails to pick up the curl
dependency, failing the build. When the dependency is fixed
manually, the resulting packing list is also wrong.
There are also some other rough edges about this port; I'll
try to address those later this week.
>How-To-Repeat:
Build net-mgmt/collectd with WITH_APACHE=yes
>Fix:
--- collectd-apache-fix.diff begins here ---
diff -ruN collectd.orig/Makefile collectd/Makefile
--- collectd.orig/Makefile 2008-03-27 11:58:26.000000000 +0100
+++ collectd/Makefile 2008-04-15 13:36:57.000000000 +0200
@@ -62,13 +62,11 @@
.if defined(WITH_DEBUG)
CONFIGURE_ARGS+= --enable-debug
-.else
-PLIST_SUB+= APACHE="@comment "
.endif
.if defined(WITH_APACHE)
CONFIGURE_ARGS+= --enable-apache
-BUILD_DEPENDS+= curl.4:${PORTSDIR}/ftp/curl
+LIB_DEPENDS+= curl.4:${PORTSDIR}/ftp/curl
PLIST_SUB+= APACHE=""
.else
CONFIGURE_ARGS+= --disable-apache
--- collectd-apache-fix.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1Jljln-000OzP-MQ>