From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Apr 1 16:26:40 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C72B6EAD for ; Wed, 1 Apr 2015 16:26:40 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AC11A655 for ; Wed, 1 Apr 2015 16:26:40 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t31GQeET037966 for ; Wed, 1 Apr 2015 16:26:40 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199052] [PATCH] Use 7 alphanumeric GH_COMMIT for WRKSRC, related to "legacy.tar.gz" (codeload) GitHub backend method Date: Wed, 01 Apr 2015 16:26:40 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 16:26:40 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199052 --- Comment #3 from lightside --- (In reply to comment #2) > but some not, if there is a need to use full commit hash, i.e. very long directory name for WRKSRC. Realistically, the need for full commit hash may be rare (to this time). Even creation of repository with many commits takes time. Personally, I didn't find abbreviated commit hash, which equals to full commit hash for some existing large repositories. But this is logical conclusion to use full commit hash, if you may want your download method works for previous versions of port, independent from future changes to repository. What I said may be not related to concrete "legacy.tar.gz" or "tar.gz" GitHub backend methods. Technically, they are the same, but with different output, I guess. I think, the possible issue with long name for WRKSRC directory is solvable with renaming to short directory name, e.g.: WRKSRC= ${WRKDIR}/${PORTNAME} # ... post-extract: @(cd ${WRKDIR} && ${MV} ${GH_PROJECT}-* ${PORTNAME}) But this is what "legacy.tar.gz" GitHub backend method (potentially) does in result. In other words, there are solutions, independent from where current ports framework takes its development. If ports framework doesn't fit (or help), it's possible to create own proper methods, when needed. -- You are receiving this mail because: You are on the CC list for the bug.