Date: Tue, 19 Jul 2022 18:02:59 GMT From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 0fe451036dad - stable/12 - Remove unused but set variable in cxgb_sge Message-ID: <202207191802.26JI2xrM077934@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=0fe451036dadbdffb980f6667e281429a6b22e4e commit 0fe451036dadbdffb980f6667e281429a6b22e4e Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2022-07-16 18:16:36 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2022-07-19 18:01:54 +0000 Remove unused but set variable in cxgb_sge Clang 15 warns: sys/dev/cxgb/cxgb_sge.c:1290:21: error: variable 'txsd' set but not used [-Werror,-Wunused-but-set-variable] struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx]; ^ It appears 'txsd' is a leftover from a previous refactoring (see 3f345a5d09b6), but is no longer used for anything, and can be removed without any functional change. MFC after: 3 days Reviewed by: np Differential Revision: https://reviews.freebsd.org/D35833 (cherry picked from commit cab040039d6fe1b2a6de8f2ba2cc882c313d3c75) --- sys/dev/cxgb/cxgb_sge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/cxgb/cxgb_sge.c b/sys/dev/cxgb/cxgb_sge.c index 5c5d1f902f30..7a6bd2a48ec0 100644 --- a/sys/dev/cxgb/cxgb_sge.c +++ b/sys/dev/cxgb/cxgb_sge.c @@ -1292,7 +1292,6 @@ write_wr_hdr_sgl(unsigned int ndesc, struct tx_desc *txd, struct txq_state *txqs { struct work_request_hdr *wrp = (struct work_request_hdr *)txd; - struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx]; if (__predict_true(ndesc == 1)) { set_wr_hdr(wrp, htonl(F_WR_SOP | F_WR_EOP | V_WR_DATATYPE(1) | @@ -1323,12 +1322,10 @@ write_wr_hdr_sgl(unsigned int ndesc, struct tx_desc *txd, struct txq_state *txqs fp += avail; txd++; - txsd++; if (++txqs->pidx == txq->size) { txqs->pidx = 0; txqs->gen ^= 1; txd = txq->desc; - txsd = txq->sdesc; } /*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202207191802.26JI2xrM077934>