From owner-cvs-all Sun Dec 16 14:41: 0 2001 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 4E80F37B419; Sun, 16 Dec 2001 14:40:56 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id fBGMeta08290; Sun, 16 Dec 2001 15:40:55 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost [127.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id fBGMeqM71226; Sun, 16 Dec 2001 15:40:54 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200112162240.fBGMeqM71226@harmony.village.org> To: Luigi Rizzo Subject: Re: cvs commit: src/sys/sys sysctl.h src/sys/kern kern_sysctl.c src/sbin/sysctl sysctl.8 sysctl.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Sun, 16 Dec 2001 13:33:55 PST." <20011216133355.A71423@iguana.aciri.org> References: <20011216133355.A71423@iguana.aciri.org> <200112160255.fBG2tfi90738@freefall.freebsd.org> <200112160740.fBG7eCM68417@harmony.village.org> Date: Sun, 16 Dec 2001 15:40:52 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20011216133355.A71423@iguana.aciri.org> Luigi Rizzo writes: : On Sun, Dec 16, 2001 at 12:40:12AM -0700, Warner Losh wrote: : > In message <200112160255.fBG2tfi90738@freefall.freebsd.org> Luigi Rizzo writes: : > : Note to developers: have a look at your code, there are a number of : > : variables which do not have a description. : > : > Someone else did this before, but phk backed it out because it didn't : > do i18n. : : Looking at the commit logs, it seems that the reason was perceived : code bloat. Maybe this is not an issue anymore, but just in case : someone is interested, the kernel I am testing has a total of 552 : sysctl vars (sysctl -dA), 323 of which have a non-empty description. : : Just the variable names (sysctl -A |awk '{print $1}' | wc -c) : take ~12KB, whereas sysctl -dA | wc -c says 23050. Seems more than : tolerable, it is just 1% of the kernel size. : Compressed, these are 3415 and 7174 bytes respectively. Code bloat was the other reason... I suspect that people that are that tight on space (and there are several that use FreeBSD where an extra 24k is a big deal) will likely invent a kernel option to compile them out. However, there are a number of areas in the kernel that we're free and loose with the code bloat wrt error messages and the like. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message