From owner-freebsd-bugs@FreeBSD.ORG  Mon Dec  6 17:00:23 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A8E99106564A
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  6 Dec 2010 17:00:23 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 977CC8FC17
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  6 Dec 2010 17:00:23 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oB6H0NVX034621
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 6 Dec 2010 17:00:23 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oB6H0NSV034600;
	Mon, 6 Dec 2010 17:00:23 GMT (envelope-from gnats)
Date: Mon, 6 Dec 2010 17:00:23 GMT
Message-Id: <201012061700.oB6H0NSV034600@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: John Baldwin <jhb@freebsd.org>
Cc: 
Subject: Re: kern/152768: [mfi] Weird check in mfi(4)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: John Baldwin <jhb@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Dec 2010 17:00:23 -0000

The following reply was made to PR kern/152768; it has been noted by GNATS.

From: John Baldwin <jhb@freebsd.org>
To: Scott Long <scottl@samsco.org>
Cc: bug-followup@freebsd.org,
 saw@online.de
Subject: Re: kern/152768: [mfi] Weird check in mfi(4)
Date: Mon, 6 Dec 2010 11:59:38 -0500

 On Monday, December 06, 2010 11:45:32 am Scott Long wrote:
 > John,
 > 
 > Had a chance to review this, and the patch looks reasonable.  This code was 
 basically a copy-and-paste from the aac driver, which will also need a similar 
 change.
 > 
 > Scott
 
 Ok, does this look right for aac?
 
 Index: aac_cam.c
 ===================================================================
 --- aac_cam.c	(revision 216122)
 +++ aac_cam.c	(working copy)
 @@ -587,7 +587,8 @@
  				    (device == T_PROCESSOR) ||
  				    (sc->flags & AAC_FLAGS_CAM_PASSONLY))
  					ccb->csio.data_ptr[0] =
 -					    ((device & 0xe0) | T_NODEVICE);
 +					    ((ccb->csio.data_ptr[0] & 0xe0) |
 +					    T_NODEVICE);
  				} else if (ccb->ccb_h.status == CAM_SEL_TIMEOUT &&
  					ccb->ccb_h.target_lun != 0) {
  					/* fix for INQUIRYs on Lun>0 */
 
 -- 
 John Baldwin