From owner-svn-src-head@FreeBSD.ORG Thu Feb 6 22:55:31 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0FD50D99; Thu, 6 Feb 2014 22:55:31 +0000 (UTC) Received: from mail-wg0-x22f.google.com (mail-wg0-x22f.google.com [IPv6:2a00:1450:400c:c00::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2D2601E25; Thu, 6 Feb 2014 22:55:30 +0000 (UTC) Received: by mail-wg0-f47.google.com with SMTP id m15so1732345wgh.26 for ; Thu, 06 Feb 2014 14:55:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=OcgouOCpkuBh3iliqPLNL16DxORfyylsEXVISpLkyDE=; b=JnH97hZDE3cj71rMesyG4viDXi7YQBXOngmGigAz1XpqNaqoPLXmzBM5MnUJxU8e8T cbktngYBEXIiIfudyzv0hrddqeAp2gCYjg8UvpEnIonscCiSd1PQ9RMli2m46034+nQY C2cl0Djqa6L4w2vzIk/BAHqFxXkiiABSwhZVgEjbNg8VIBxW076SlIOgQcmBKYuNxyeC +f3JxGkypVw8Mr3VHmp6bVGqF+kVJ3eDWYiAy0ks34GONtT9iZTrRbsD54ZXc9oon4qr g0grWj/uoYTRPlfpqrHTUo2wHIEeT/2gBoaUoHsHS2wiBX+Y1XcRhqvMsNyuYOLqg9p6 iuWg== MIME-Version: 1.0 X-Received: by 10.180.97.37 with SMTP id dx5mr1241728wib.53.1391727328544; Thu, 06 Feb 2014 14:55:28 -0800 (PST) Sender: asomers@gmail.com Received: by 10.194.168.197 with HTTP; Thu, 6 Feb 2014 14:55:28 -0800 (PST) In-Reply-To: <201401300744.s0U7iNLt016044@svn.freebsd.org> References: <201401300744.s0U7iNLt016044@svn.freebsd.org> Date: Thu, 6 Feb 2014 15:55:28 -0700 X-Google-Sender-Auth: 3WAJ7-8s-qHR9mkQZpErFaNsaTc Message-ID: Subject: Re: svn commit: r261283 - in head: contrib/libc++ contrib/libc++/include contrib/libc++/include/experimental contrib/libc++/include/ext contrib/libc++/src etc/mtree lib/libc++ sys/sys tools/build/mk From: Alan Somers To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Feb 2014 22:55:31 -0000 On Thu, Jan 30, 2014 at 12:44 AM, Dimitry Andric wrote: > Author: dim > Date: Thu Jan 30 07:44:22 2014 > New Revision: 261283 > URL: http://svnweb.freebsd.org/changeset/base/261283 > > Log: > Import libc++ 3.4 release. This contains a lot of bugfixes, and some > preliminary support for C++1y. > > MFC after: 3 weeks > > Added: ... > head/contrib/libc++/include/locale This broke the build when WITH_TESTS=yes is set. contrib/atf/atf-c++/detail/application.cpp fails to compile as shown below. All that file does is #include several standard headers, so I think the problem is strictly within libc++. Tinderbox probably didn't catch it because the base system includes so little C++, and WITH_TESTS is off by default. By inspection, I can't tell why locale compiled before this change; the offending LOC are identical. Can you please take a look? c++ -fpic -DPIC -O2 -pipe -DHAVE_CONFIG_H -DATF_ARCH='"amd64"' -DATF_BUILD_CC='"cc "' -DATF_BUILD_CFLAGS='"-O2 -pipe "' -DATF_BUILD_CPP='"cpp "' -DATF_BUILD_CPPFLAGS='""' -DATF_BUILD_CXX='"c++ "' -DATF_BUILD_CXXFLAGS='"-O2 -pipe"' -DATF_CONFDIR='"/etc/atf"' -DATF_C_TESTS_BASE='"/usr/tests/lib/atf/libatf-c"' -DATF_INCLUDEDIR='"/usr/include"' -DATF_LIBDIR='"/usr/lib"' -DATF_LIBEXECDIR='"/usr/libexec"' -DATF_MACHINE='"amd64"' -DATF_M4='"/usr/bin/m4"' -DATF_PKGDATADIR='"/usr/share/atf"' -DATF_SHELL='"/bin/sh"' -DATF_WORKDIR='"/tmp"' -I/usr/home/alans/freebsd/head/contrib/atf -I/usr/home/alans/freebsd/head/lib/atf/libatf-c++/../libatf-c -I. -DHAVE_CONFIG_H -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wpointer-arith -Wno-uninitialized -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-c++11-extensions -c /usr/home/alans/freebsd/head/contrib/atf/atf-c++/detail/application.cpp -o application.So In file included from /usr/home/alans/freebsd/head/contrib/atf/atf-c++/detail/application.cpp:42: In file included from /vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/iostream:40: In file included from /vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/istream:156: In file included from /vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/ostream:133: /vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/locale:1015:27: error: comparison of integers of different signs: 'long' and 'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare] if (__a_end - __a == __buf.size()) ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ /vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/locale:1065:27: error: comparison of integers of different signs: 'long' and 'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare] if (__a_end - __a == __buf.size()) ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ /vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/locale:1119:27: error: comparison of integers of different signs: 'long' and 'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare] if (__a_end - __a == __buf.size()) ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ 3 errors generated. *** [application.So] Error code 1 bmake[4]: stopped in /usr/home/alans/freebsd/head/lib/atf/libatf-c++ 1 error -Alan