From owner-cvs-src@FreeBSD.ORG Fri Apr 22 20:09:43 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99AA516A4CF; Fri, 22 Apr 2005 20:09:43 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2F8843D48; Fri, 22 Apr 2005 20:09:42 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j3MKD3TX012324; Fri, 22 Apr 2005 23:13:03 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 97830-09; Fri, 22 Apr 2005 23:09:38 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j3MKD29Z012321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Apr 2005 23:13:02 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j3MK9jLg029935; Fri, 22 Apr 2005 23:09:45 +0300 (EEST) (envelope-from ru) Date: Fri, 22 Apr 2005 23:09:44 +0300 From: Ruslan Ermilov To: Bruce Evans Message-ID: <20050422200944.GC23926@ip.net.ua> References: <200504182110.j3ILAc8J031298@repoman.freebsd.org> <20050418.152011.74745144.imp@bsdimp.com> <20050419182938.GA27941@dragon.NUXI.org> <20050420055904.GA33015@ip.net.ua> <20050420161212.GA52582@dragon.NUXI.org> <20050421125501.W88810@delplex.bde.org> <20050421070011.GA81229@ip.net.ua> <20050421171036.Q2082@epsplex.bde.org> <20050421185925.GA85015@ip.net.ua> <20050422233107.J93439@delplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="96YOpH+ONegL0A3E" Content-Disposition: inline In-Reply-To: <20050422233107.J93439@delplex.bde.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Warner Losh cc: David O'Brien Subject: Re: cvs commit: src/sys/conf kmod.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2005 20:09:43 -0000 --96YOpH+ONegL0A3E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Apr 22, 2005 at 11:50:52PM +1000, Bruce Evans wrote: > On Thu, 21 Apr 2005, Ruslan Ermilov wrote: >=20 > >On Thu, Apr 21, 2005 at 05:43:25PM +1000, Bruce Evans wrote: > >>Another dependency bug that sometimes bites me: "make" doesn't work > >>after "make clean", at least under the old version of -current that I > >>use, because dependencies for lots of generated sources (like device_if= =2Ec > >>(?)) are missing. Dependencies for older generated files like > >>vnode_if.c are handled correctly, and "make depend" doesn't have > >>the problem because the necessary dependencies are in BEFORE_DEPEND. > >> > >Maybe this is only an old bug, as there are these lines in kern.post.mk: > > > >.if !exists(${.OBJDIR}/.depend) > >${SYSTEM_OBJS}: assym.s vnode_if.h ${BEFORE_DEPEND:M*.h}=20 > >${MFILES:T:S/.m$/.h/} > >.endif >=20 > Note that this only works when .depend doesn't exist (it works using the > usual hack of making all objects depend on all geaders in that case). >=20 > >At least "make -n kernel >/dev/null" after "make clean" doesn't > >complain now. >=20 > I check that it doesn't work after "make depend; make; make clean". The > first error is for amd64's GENERIC is: >=20 > %%% > In file included from ./../../../dev/aic7xxx/aic7xxx_osm.h:44, > from aic7xxx_reg_print.c:9: > ../../../sys/bus.h:461:23: device_if.h: No such file or directory > %%% >=20 > This can be worked around using either "rm .depend" or "make cleandepend" > so that the above hack works, or using "make depend" which creates all > the generated sources as a side effect. >=20 Should be fixed now. The problem was that aic*_reg_print.c's were not in CFILES in a makefile produced by config(8), making the corresponding =2Eo files to *NOT* appear in .depend. I expanded {}'s in sys/conf/files and that did the trick (config(8) doesn't understand the {} syntax; make(1) does, in dependency lines). > I agree with the change in behaviour in your other mail (make > "make depend" behave the same for kernels as for applications). To > be complete, the stupid message printed by config(8) should be expanded > to give a reminder about not forgetting to run ``make cleandepend'' ;-). >=20 Done. :-) Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --96YOpH+ONegL0A3E Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCaVoIqRfpzJluFF4RAhCLAJ9g8E1Kmu62f/LgifdyMN0k3VePMwCgjYTf BkD0VBWuW/RpH7Jl+QIyYGg= =6wPb -----END PGP SIGNATURE----- --96YOpH+ONegL0A3E--