From owner-freebsd-hackers@FreeBSD.ORG Sat Aug 22 00:44:39 2009 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80BE1106568B; Sat, 22 Aug 2009 00:44:39 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.248]) by mx1.freebsd.org (Postfix) with ESMTP id 27D158FC17; Sat, 22 Aug 2009 00:44:38 +0000 (UTC) Received: by an-out-0708.google.com with SMTP id d14so372868and.13 for ; Fri, 21 Aug 2009 17:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=sg6Lm1cqfh3BxtbFqTmq4StabKTYzKO7wAGdWIzqkKY=; b=IzzsxeISv0gPEEqxAWyZFW1aTVnq0mp9vKa+zJuGRY+Omq48h8JeInVXCLymPCUHng am6cc68msGU6MTGOPXykGbEd+geKFiOyUuh2tUUne5AWJuHRGofW6ZZkvWZtaG9rjMHb KPHPJMNS07zuM1IoYjBKoOKUaqQhTCnjss+W8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=HTlEnbjZoTZv2KwIzaxcqM+cWPXD5f6Xrap635EjeKjy+AVLYDCvmiKmBBlMLBgdB9 Z19Vev1ORFld8UojIWzUKSjfit/uo4PPlnOk1O0f+dFuimNA/GWlTRQJULW7tPCs6ao3 LIHntE/sq6lxt0X3r/foMKWbG5NdqEb9+cEUc= MIME-Version: 1.0 Sender: mat.macy@gmail.com Received: by 10.100.55.18 with SMTP id d18mr1899444ana.80.1250900025724; Fri, 21 Aug 2009 17:13:45 -0700 (PDT) In-Reply-To: <20090821164312.641fe2bd@dev.lan.Awfulhak.org> References: <20090821164312.641fe2bd@dev.lan.Awfulhak.org> Date: Fri, 21 Aug 2009 17:13:45 -0700 X-Google-Sender-Auth: 0378d475c0acc9ae Message-ID: <3c1674c90908211713j36415b96q58b0ed66cc82713f@mail.gmail.com> From: Kip Macy To: Brian Somers Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org Subject: Re: kernel panics in in_lltable_lookup (with INVARIANTS) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2009 00:44:39 -0000 Try this: Index: sys/net/flowtable.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/net/flowtable.c (revision 196382) +++ sys/net/flowtable.c (working copy) @@ -688,6 +688,12 @@ struct rtentry *rt =3D ro->ro_rt; struct ifnet *ifp =3D rt->rt_ifp; + if (ifp->if_flags & IFF_POINTOPOINT) { + RTFREE(rt); + ro->ro_rt =3D NULL; + return (ENOENT); + } + if (rt->rt_flags & RTF_GATEWAY) l3addr =3D rt->rt_gateway; else You'll need to apply this by hand as gmail munges the formatting. -Kip On Fri, Aug 21, 2009 at 16:43, Brian Somers wrote: > Hi, > > I've been working on a fix to address an issue that came up with > our update of openssh-5. =A0The issue is that openssh-5 now uses > pipe() to create stdin/stdout channels between sshd and the server > side program where it used to use socketpair(). =A0Because it uses > pipe(), stdin is no longer bi-directional and cannot be used for both > input and output by a child process. =A0This breaks the use of ssh > as a tunnel with ppp on either end (set device "!ssh -e none host > ppp -direct label") > > I talked with des@ for a while and then with the openssh folks and > have not been able to resolve the issues in openssh that made them > choose to enforce the use of pipe() over socketpair(). =A0I now have a > patch to ppp that makes ppp detect that it's connected via pipe() and > causes it to use stdin for input and stdout for output (usually it expect= s > just one descriptor). =A0Although I'm happy with the patch and planned on > requesting permission to commit, I've bumped into a show-stopper > that seems unrelated, so I thought I'd ask here if anyone has seen > this or has any suggestions as to what the problem might be. > > The issue.... > > I'm seeing a panic when I send traffic through a ppp link: > > panic string is: sin_family 18 > Stack trace starts: > =A0 =A0in_lltable_lookup() > =A0 =A0llentry_update() > =A0 =A0flowtable_lookup() > =A0 =A0ip_output() > =A0 =A0.... > > The panic is due to a KASSERT in in_lltable_lookup() that expects the > sockaddr to be AF_INET. =A0Number 18 is AF_LINK. > > AFAICT this is happening while setting up a temporary route for the > first outbound packet. =A0I haven't been able to do much investigation > yet due to other patches in my tree that seem to have broken all my > kernel symbols, but once I get a clean rebuild I should be back in > business. > > If anyone has any suggestions, I'm all ears! > > Cheers. > > -- > Brian Somers =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 > Don't _EVER_ lose your sense of humour ! =A0 =A0 =A0 =A0 =A0 =A0 =A0 > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= " > --=20 When harsh accusations depart too far from the truth, they leave bitter consequences. --Tacitus