From owner-svn-src-head@freebsd.org Fri Apr 5 20:27:51 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2EF01155D9E5; Fri, 5 Apr 2019 20:27:51 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F38C73AE7; Fri, 5 Apr 2019 20:27:50 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x634.google.com with SMTP id w24so3628308plp.2; Fri, 05 Apr 2019 13:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LSFAwPlGQeHy6oATfHRNZhpoO+x01HpAC5eFktspmgI=; b=gj6zz6lOZB98q5p1ZAjBH7CQJZ0ZEmTswbP1oO3uwU4xJsoCjCIN7zE6TTW8WwuwFb MjbY3MolsyM2YecUGhaQxOmITIxSlu18ugICtwBs8g3IWiGT6T+c5R8qYFvA/yxGghTd Np66RsLfMjN3GL39ZC35RrrNCK0ced0fGABt1JvV8wEOfMdYXi0If0O/JImHQKha1Ayb kFc9ExcKmPZrqrpSSDCiIOezb8Mwja4chXlgYu9j8gP6mszIrjE4RVkK4yf49EbOkJxP lFErTIwz/rt+pADBrPmb4IMeQYLqwDcgyIsxAcCJ2RxvSWozG+GSadifMl6VftpOpKWP PzxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LSFAwPlGQeHy6oATfHRNZhpoO+x01HpAC5eFktspmgI=; b=Le429qUEKTuAx2tLm0GeganpuLHXp811Zclb8Gjfm37JjAleVOulZb0jh+hYvG01vc ij4100hWFrK6DjSsxlBp+rtKg+g5XXq+ViSbRetQmF4pS/ODL3MVsZxSjJVju7hr5zoS n9kzysmaClmKI+mVkH6uQ1cMRYNfoyUGiFGNtInJqm8O+ywhf58Hf7NHtaApnPoLXnYd KLjsoVJRyqNp2tBOcb2VqML5yO2rE7QVMJuiXx5BD/drGrHLasFbyXY9Zh5+a+oB1vV1 YO6za8apySQOKnrQTuDWy6dZd9iXHWR9cMuT/AzYZJDRw/cBtN85ottgNwyMTfhkfX7R 5d5Q== X-Gm-Message-State: APjAAAWqMkF7/tOSjPvkZ4iye0lQB4C3PGzlt6kVZ7d4vWoG9ozSDAU6 Lo78Qn3e3Wx8o13xQ/tTmMA5IXVt X-Google-Smtp-Source: APXvYqwnRh8bkWsANubmTcH0/Me819282vAlUJG6YfPQ0jKT6RJti7xt5EFsaka8qkdmahzJ9C4VUQ== X-Received: by 2002:a17:902:a7:: with SMTP id a36mr15380099pla.267.1554496069114; Fri, 05 Apr 2019 13:27:49 -0700 (PDT) Received: from ?IPv6:2607:fb90:82aa:82cf:c822:32d6:876f:8ca? ([2607:fb90:82aa:82cf:c822:32d6:876f:8ca]) by smtp.gmail.com with ESMTPSA id n22sm26881776pfa.51.2019.04.05.13.27.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 13:27:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs From: Enji Cooper X-Mailer: iPhone Mail (16E227) In-Reply-To: <201904052022.x35KMCo0041093@gndrsh.dnsmgr.net> Date: Fri, 5 Apr 2019 13:27:47 -0700 Cc: cem@freebsd.org, Ed Maste , Xin LI , src-committers , svn-src-all , svn-src-head Content-Transfer-Encoding: quoted-printable Message-Id: References: <201904052022.x35KMCo0041093@gndrsh.dnsmgr.net> To: rgrimes@freebsd.org X-Rspamd-Queue-Id: 8F38C73AE7 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.97)[-0.971,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 20:27:51 -0000 On Apr 5, 2019, at 13:22, Rodney W. Grimes wrote= : >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: >>>=20 >>>> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: >>>>=20 >>>=20 >>>>> +static const u_char dot_name[] =3D { >>>>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; >>>>> +static const u_char dotdot_name[] =3D { >>>>> + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; >>>>> + >>>=20 >>> They are all either '.' or ' ', the commas are just list separators. >>> IMO spaces after the commas would make it slightly easier to see. >>=20 >> Would it make sense to just use the normal string syntax for char >> array assignment? >>=20 >> static const u_char dot_name[11] =3D ". "; >> static const u_char dotdot_name[11] =3D ".. "; >>=20 >> Seems more clear to me. >=20 > To try and end this thread, I already stated it was in review, > let me get a pointer to it, if you have comments please post > them there: > https://reviews.freebsd.org/D19829 It would probably be a good idea to add a comment in the code to document th= e intention. Thanks, -Enji=