From owner-cvs-all@FreeBSD.ORG Thu Aug 18 22:03:28 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F87D16A41F; Thu, 18 Aug 2005 22:03:28 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from haven.freebsd.dk (haven.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id A543943D45; Thu, 18 Aug 2005 22:03:27 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (unknown [192.168.48.2]) by haven.freebsd.dk (Postfix) with ESMTP id 68A85BC66; Thu, 18 Aug 2005 22:03:25 +0000 (UTC) To: Robert Watson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 18 Aug 2005 21:12:33 BST." <20050818211150.W32515@fledge.watson.org> Date: Fri, 19 Aug 2005 00:03:25 +0200 Message-ID: <25621.1124402605@phk.freebsd.dk> Sender: phk@phk.freebsd.dk Cc: cvs-src@FreeBSD.org, Maxim.Sobolev@portaone.com, cvs-all@FreeBSD.org, John Baldwin , src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2005 22:03:28 -0000 In message <20050818211150.W32515@fledge.watson.org>, Robert Watson writes: > >On Thu, 18 Aug 2005, John Baldwin wrote: > >> I've still yet to see what the real panic is. For one thing, if the >> foo_stop method does its jobs, the ethernet hardware shouldn't be >> generating interrupts. The stop method should be shutting the card down >> (i.e. turning off the receiver and transmitter for example). Is your >> ethernet driver sharing an interrupt with another device and the other >> device is interrupting? In that case, the ethernet driver would have >> the same panic if you did an 'ifconfig foo0 down' and then the other >> device interrupted. So, I think clearing IFF_UPP in foo_shutdown() is >> wrong. foo_stop() should really be sufficient, and foo_intr() should be >> able to handle a spurious interrupt while the interface is stopped >> without panicing since it already needs to do so to handle the shared >> interrupt case. > >Ideally, I'd like to see device drivers stop setting or clearing >stack-owned bits, such as IFF_UP, IFF_PROMISC, etc. However, we probably >have a ways to go before we're there. I belive if the driver doesn't to this, you have to explicity specify "up" on the ifconfig command line. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.