From owner-cvs-all@FreeBSD.ORG  Wed Mar 29 01:41:14 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 38F0D16A420;
	Wed, 29 Mar 2006 01:41:14 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EC6E043D4C;
	Wed, 29 Mar 2006 01:41:13 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from [127.0.0.1] (root@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2T1fATf035686;
	Wed, 29 Mar 2006 01:41:11 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4429E5BE.7070700@freebsd.org>
Date: Wed, 29 Mar 2006 09:41:18 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060302
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Daniel Eischen <deischen@freebsd.org>
References: <Pine.GSO.4.43.0603282025220.18701-100000@sea.ntplx.net>
In-Reply-To: <Pine.GSO.4.43.0603282025220.18701-100000@sea.ntplx.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org,
	Alexander Kabaev <kabaev@gmail.com>, Dag-Erling Smorgrav <des@freebsd.org>
Subject: Re: cvs commit: src/libexec/rtld-elf/i386 rtld_machdep.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Mar 2006 01:41:14 -0000

Daniel Eischen wrote:
> On Tue, 28 Mar 2006, Alexander Kabaev wrote:
> 
> 
>>On Tue, 28 Mar 2006 18:28:07 +0000 (UTC)
>>Dag-Erling Smorgrav <des@FreeBSD.org> wrote:
>>
>>
>>>des         2006-03-28 18:28:07 UTC
>>>
>>>  FreeBSD src repository
>>>
>>>  Modified files:
>>>    libexec/rtld-elf/i386 rtld_machdep.h
>>>  Log:
>>>  Don't use dbg if it isn't defined (such as when this file is used by
>>>  code outside of rtld-elf)
>>>
>>>  Revision  Changes    Path
>>>  1.11      +2 -0      src/libexec/rtld-elf/i386/rtld_machdep.h
>>>
>>>http://cvsweb.FreeBSD.org/src/libexec/rtld-elf/i386/rtld_machdep.h.diff?r1=1.10&r2=1.11
>>
>>The use of this file in threading libraries is illegal and should be
>>fixed instead.
> 
> 
> David Xu probably knows more about this, but it's needed for
> the debugger.  rtld.h is included by the thread libraries,
> so rtld_machdep.h comes along for the ride.
> 

It is being used to calculate TLS address for debugger, either thread
libraries or libthread_db have to use it, it is not important who is 
using it, fixing it in rtld header files is needed.

David Xu